api: Lamp values now always between 0 and 1.

Author: freezy

Editor/Descriptors/GetLampUnitDescriptor.cs

@@ -45,7 +45,7 @@ protected override void DefinedPort(IUnitPort port, UnitPortDescription desc)
 					desc.summary = "The ID of the lamp for which the intensity is returned.";
 					break;
 				case nameof(GetLampUnit.Value):
-					desc.summary = "The intensity of the lamp.";
+					desc.summary = "The intensity of the lamp (0-1).";
 					break;
 				case nameof(GetLampUnit.IsEnabled):
 					desc.summary = "Whether the intensity is larger than 0.";

Editor/Descriptors/LampEventUnitDescriptor.cs

@@ -43,7 +43,7 @@ protected override void DefinedPort(IUnitPort port, UnitPortDescription desc)
 					desc.summary = "The ID of the lamp that changed its intensity.";
 					break;
 				case nameof(LampEventUnit.Value):
-					desc.summary = "The new intensity of the lamp (0-255).";
+					desc.summary = "The new intensity of the lamp (0-1).";
 					break;
 				case nameof(LampEventUnit.IsEnabled):
 					desc.summary = "Whether the intensity is larger than 0.";

Editor/Descriptors/SetLampUnitDescriptor.cs

@@ -0,0 +1,53 @@
+// Visual Pinball Engine
+// Copyright (C) 2021 freezy and VPE Team
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+// ReSharper disable UnusedType.Global
+
+using Unity.VisualScripting;
+using VisualPinball.Unity.Editor;
+using IconSize = VisualPinball.Unity.Editor.IconSize;
+
+namespace VisualPinball.Unity.VisualScripting.Editor
+{
+	[Descriptor(typeof(SetLampUnit))]
+	public class SetLampUnitDescriptor : UnitDescriptor<SetLampUnit>
+	{
+		public SetLampUnitDescriptor(SetLampUnit target) : base(target)
+		{
+		}
+
+		protected override string DefinedSummary()
+		{
+			return "This node assigns a given value to a lamp defined by its mapped ID. This will also trigger the lamp changed event and update the internal status.";
+		}
+
+		protected override EditorTexture DefinedIcon() => EditorTexture.Single(Unity.Editor.Icons.Light(IconSize.Large, IconColor.Orange));
+
+		protected override void DefinedPort(IUnitPort port, UnitPortDescription desc)
+		{
+			base.DefinedPort(port, desc);
+
+			switch (port.key) {
+				case nameof(SetLampUnit.Id):
+					desc.summary = "The ID of the lamp for which the intensity is returned.";
+					break;
+				case nameof(SetLampUnit.Value):
+					desc.summary = "The intensity of the lamp (0-1).";
+					break;
+			}
+		}
+	}
+}

Editor/Descriptors/SetLampUnitDescriptor.cs.meta

@@ -71,7 +71,7 @@ public void SetCoil(string id, bool isEnabled)
 			OnCoilChanged?.Invoke(this, new CoilEventArgs(id, isEnabled));
 		}
 
-		public void SetLamp(string id, int value, bool isCoil = false, LampSource source = LampSource.Lamp)
+		public void SetLamp(string id, float value, bool isCoil = false, LampSource source = LampSource.Lamp)
 		{
 			OnLampChanged?.Invoke(this, new LampEventArgs(id, value, isCoil, source));
 		}

Runtime/Gamelogic/VisualScriptingGamelogicEngine.cs

@@ -47,7 +47,7 @@ protected override void Definition()
 
 			Id = ValueInput(nameof(Id), string.Empty);
 
-			Value = ValueOutput<int>(nameof(Value));
+			Value = ValueOutput<float>(nameof(Value));
 			IsEnabled = ValueOutput<bool>(nameof(IsEnabled));
 		}
 

Runtime/Nodes/Lamps/LampEventUnit.cs

@@ -19,7 +19,7 @@
 
 namespace VisualPinball.Unity.VisualScripting
 {
-	[UnitTitle("Set Lamp")]
+	[UnitTitle("Set Lamp Value")]
 	[UnitCategory("Visual Pinball")]
 	public class SetLampUnit : GleUnit
 	{
@@ -45,27 +45,25 @@ protected override void Definition()
 			OutputTrigger = ControlOutput(nameof(OutputTrigger));
 
 			Id = ValueInput<string>(nameof(Id), string.Empty);
-			Value = ValueInput<int>(nameof(Value), 0);
+			Value = ValueInput<float>(nameof(Value), 0f);
 
 			Requirement(Id, InputTrigger);
 			Succession(InputTrigger, OutputTrigger);
 		}
 
 		private ControlOutput Process(Flow flow)
 		{
-			var gle = flow.stack.gameObject.GetComponentInParent<VisualScriptingGamelogicEngine>();
 
-			if (gle != null) {
-
-				var id = flow.GetValue<string>(Id);
-				var value = flow.GetValue<int>(Value);
-
-				gle.SetLamp(id, value);
-
-			} else {
+			if (!AssertGle(flow)) {
 				Debug.LogError("Cannot find GLE.");
+				return OutputTrigger;
 			}
 
+			var id = flow.GetValue<string>(Id);
+			var value = flow.GetValue<float>(Value);
+
+			Gle.SetLamp(id, value);
+
 			return OutputTrigger;
 		}
 	}