Abstract the analyzer stuff.

Author: freezy

Editor/GleUnitAnalyzer.cs

@@ -1,18 +1,26 @@
 using System.Collections.Generic;
 using Unity.VisualScripting;
+using VisualPinball.Unity;
 using VisualPinball.Unity.VisualScripting;
 
 namespace Editor
 {
+
 	[Analyser(typeof(SwitchEventUnit))]
-	public class GleUnitAnalyser : UnitAnalyser<SwitchEventUnit>
+	public class SwitchEventUnitAnalyzer : GleUnitAnalyser<SwitchEventArgs>
+	{
+		public SwitchEventUnitAnalyzer(GraphReference reference, SwitchEventUnit target) : base(reference, target)
+		{
+		}
+	}
+
+	public abstract class GleUnitAnalyser<TArgs> : UnitAnalyser<GleEventUnit<TArgs>>
 	{
-		public GleUnitAnalyser(GraphReference reference, SwitchEventUnit target) : base(reference, target) { }
+		protected GleUnitAnalyser(GraphReference reference, GleEventUnit<TArgs> target) : base(reference, target) { }
 
 		protected override IEnumerable<Warning> Warnings()
 		{
-			foreach (var baseWarning in base.Warnings())
-			{
+			foreach (var baseWarning in base.Warnings()) {
 				yield return baseWarning;
 			}
 

Editor/Widgets/SwitchEventUnitWidget.cs

@@ -24,7 +24,6 @@ namespace VisualPinball.Unity.VisualScripting
 	[Widget(typeof(SwitchEventUnit))]
 	public sealed class SwitchEventUnitWidget : UnitWidget<SwitchEventUnit>
 	{
-
 		protected override NodeColorMix baseColor => GleAvailable ? NodeColorMix.TealReadable : new NodeColorMix { red = 1f, green = 0f, blue = 0f };
 		private bool GameObjectAvailable => reference != null && reference.gameObject != null;
 		private bool GleAvailable => GameObjectAvailable && Gle != null;
@@ -63,7 +62,6 @@ private IEnumerable<string> GetNameSuggestions()
 			}
 			var gle = Gle;
 			return gle == null ? new List<string>() : gle.AvailableSwitches.Select(lamp => lamp.Id).ToList();
-
 		}
 	}
 }

Runtime/Events/Nodes/GleEventUnit.cs

@@ -0,0 +1,27 @@
+// Visual Pinball Engine
+// Copyright (C) 2021 freezy and VPE Team
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+using System.Collections.Generic;
+using Unity.VisualScripting;
+
+namespace VisualPinball.Unity.VisualScripting
+{
+	public abstract class GleEventUnit<TArgs> : EventUnit<TArgs>
+	{
+		[DoNotSerialize]
+		public readonly List<string> Errors = new();
+	}
+}

Runtime/Events/Nodes/GleEventUnit.cs.meta

@@ -14,16 +14,13 @@
 // You should have received a copy of the GNU General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
-using System;
-using System.Collections.Generic;
 using Unity.VisualScripting;
-using UnityEngine;
 
 namespace VisualPinball.Unity.VisualScripting
 {
 	[UnitTitle("On Switch Changed")]
 	[UnitCategory("Events\\Visual Pinball")]
-	public class SwitchEventUnit : EventUnit<SwitchEventArgs>
+	public class SwitchEventUnit : GleEventUnit<SwitchEventArgs>
 	{
 		[DoNotSerialize]
 		[PortLabel("Switch ID")]
@@ -33,11 +30,6 @@ public class SwitchEventUnit : EventUnit<SwitchEventArgs>
 		[PortLabel("Is Enabled")]
 		public ValueOutput enabled { get; private set; }
 
-		public VisualScriptingGamelogicEngine gle { get; private set; }
-
-		[DoNotSerialize]
-		public readonly List<string> Errors = new();
-
 		protected override bool register => true;
 
 		// Adding an EventHook with the name of the event to the list of visual scripting events.
@@ -54,12 +46,6 @@ protected override void Definition()
 			enabled = ValueOutput<bool>(nameof(enabled));
 		}
 
-		public override void Instantiate(GraphReference instance)
-		{
-			base.Instantiate(instance);
-			Debug.Log("Switch event instantiated.");
-		}
-
 		protected override void AssignArguments(Flow flow, SwitchEventArgs args)
 		{
 			flow.SetValue(enabled, args.IsEnabled);