🚨 Improve tests

Author: VincentLanglet

TwigCS/Tests/AbstractSniffTest.php

@@ -3,6 +3,7 @@
 namespace TwigCS\Tests;
 
 use \Exception;
+use \ReflectionClass;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Twig\Loader\LoaderInterface;
@@ -43,16 +44,16 @@ public function setUp()
     }
 
     /**
-     * @param string         $filename
      * @param SniffInterface $sniff
      * @param array          $expects
      */
-    protected function checkGenericSniff($filename, SniffInterface $sniff, array $expects)
+    protected function checkGenericSniff(SniffInterface $sniff, array $expects)
     {
-        $file = __DIR__.'/Fixtures/'.$filename;
-
         $ruleset = new Ruleset();
         try {
+            $class = new ReflectionClass(get_called_class());
+            $file = __DIR__.'/Fixtures/'.$class->getShortName().'.twig';
+
             $ruleset->addSniff($sniff);
             $report = $this->lint->run($file, $ruleset);
         } catch (Exception $e) {

TwigCS/Tests/Fixtures/blankEOF.twig TwigCS/Tests/Fixtures/BlankEOFTest.twigTwigCS/Tests/Fixtures/blankEOF.twig renamed to TwigCS/Tests/Fixtures/BlankEOFTest.twig

@@ -10,9 +10,9 @@
  */
 class BlankEOFTest extends AbstractSniffTest
 {
-    public function testSniff1()
+    public function testSniff()
     {
-        $this->checkGenericSniff('blankEOF.twig', new BlankEOFSniff(), [
+        $this->checkGenericSniff(new BlankEOFSniff(), [
             [4, 1],
         ]);
     }

…gCS/Tests/Fixtures/delimiterSpacing.twig …Tests/Fixtures/DelimiterSpacingTest.twigTwigCS/Tests/Fixtures/delimiterSpacing.twig renamed to TwigCS/Tests/Fixtures/DelimiterSpacingTest.twig TwigCS/Tests/Fixtures/delimiterSpacing.twig renamed to TwigCS/Tests/Fixtures/DelimiterSpacingTest.twig

@@ -10,9 +10,9 @@
  */
 class DelimiterSpacingTest extends AbstractSniffTest
 {
-    public function testSniff1()
+    public function testSniff()
     {
-        $this->checkGenericSniff('delimiterSpacing.twig', new DelimiterSpacingSniff(), [
+        $this->checkGenericSniff(new DelimiterSpacingSniff(), [
             [12, 1],
             [12, 12],
             [12, 15],

…/Tests/Fixtures/forbidCommentedCode.twig …ts/Fixtures/ForbidCommentedCodeTest.twigTwigCS/Tests/Fixtures/forbidCommentedCode.twig renamed to TwigCS/Tests/Fixtures/ForbidCommentedCodeTest.twig TwigCS/Tests/Fixtures/forbidCommentedCode.twig renamed to TwigCS/Tests/Fixtures/ForbidCommentedCodeTest.twig

@@ -10,9 +10,9 @@
  */
 class ForbidCommentedCodeTest extends AbstractSniffTest
 {
-    public function testSniff1()
+    public function testSniff()
     {
-        $this->checkGenericSniff('forbidCommentedCode.twig', new ForbidCommentedCodeSniff(), [
+        $this->checkGenericSniff(new ForbidCommentedCodeSniff(), [
             [2, 5],
         ]);
     }