From bfbc156b56679a6d5ed9dbaaa5ad56d7566f0362 Mon Sep 17 00:00:00 2001 From: Emma Date: Fri, 15 May 2026 13:24:58 -0400 Subject: [PATCH 1/6] chore: Small asmdef file fixes --- .../PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef | 2 +- .../Tests/Editor/Unity.Netcode.Editor.Tests.asmdef | 3 +-- pvpExceptions.json | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef b/com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef index b4a04f0564..d4c5ecdcb0 100644 --- a/com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef +++ b/com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef @@ -1,5 +1,5 @@ { - "name": "Unity.Netcode.GameObjects.PackageChecker.Editor", + "name": "Unity.Netcode.GameObjects.Editor.PackageChecker", "rootNamespace": "Unity.Netcode.GameObjects.Editor.PackageChecker", "references": [], "includePlatforms": [ diff --git a/com.unity.netcode.gameobjects/Tests/Editor/Unity.Netcode.Editor.Tests.asmdef b/com.unity.netcode.gameobjects/Tests/Editor/Unity.Netcode.Editor.Tests.asmdef index 581b856595..a9a05da02b 100644 --- a/com.unity.netcode.gameobjects/Tests/Editor/Unity.Netcode.Editor.Tests.asmdef +++ b/com.unity.netcode.gameobjects/Tests/Editor/Unity.Netcode.Editor.Tests.asmdef @@ -13,8 +13,7 @@ "Unity.Mathematics", "UnityEngine.TestRunner", "UnityEditor.TestRunner", - "Unity.Netcode.Runtime.Tests", - "Unity.PerformanceTesting" + "Unity.Netcode.Runtime.Tests" ], "includePlatforms": [ "Editor" diff --git a/pvpExceptions.json b/pvpExceptions.json index e92be2a8a5..334f50cde3 100644 --- a/pvpExceptions.json +++ b/pvpExceptions.json @@ -8,7 +8,7 @@ "PVP-130-2": { "errors": [ "Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.CodeGen", - "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.PackageChecker.Editor", + "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.PackageChecker", "Editor/Unity.Netcode.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor", "Tests/Editor/Unity.Netcode.Editor.Tests.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.Tests" ] From e863c307bd4757918443d2238fe9adfc31c7ea7c Mon Sep 17 00:00:00 2001 From: Emma Date: Fri, 15 May 2026 13:54:36 -0400 Subject: [PATCH 2/6] small fixes --- .../Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef | 2 +- .../Unity.Netcode.PackageChecker.Editor.asmdef | 2 +- com.unity.netcode.gameobjects/package.json | 2 +- pvpExceptions.json | 8 +------- 4 files changed, 4 insertions(+), 10 deletions(-) diff --git a/com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef b/com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef index 1b93c60458..8f94aa0a7a 100644 --- a/com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef +++ b/com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef @@ -1,5 +1,5 @@ { - "name": "Unity.Netcode.GameObjects.Editor.CodeGen", + "name": "Unity.Netcode.GameObjects.CodeGen.Editor", "rootNamespace": "Unity.Netcode.GameObjects.Editor.CodeGen", "references": [ "Unity.Netcode.Runtime", diff --git a/com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef b/com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef index d4c5ecdcb0..b4a04f0564 100644 --- a/com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef +++ b/com.unity.netcode.gameobjects/Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef @@ -1,5 +1,5 @@ { - "name": "Unity.Netcode.GameObjects.Editor.PackageChecker", + "name": "Unity.Netcode.GameObjects.PackageChecker.Editor", "rootNamespace": "Unity.Netcode.GameObjects.Editor.PackageChecker", "references": [], "includePlatforms": [ diff --git a/com.unity.netcode.gameobjects/package.json b/com.unity.netcode.gameobjects/package.json index 04492deaa0..a37383e00d 100644 --- a/com.unity.netcode.gameobjects/package.json +++ b/com.unity.netcode.gameobjects/package.json @@ -2,7 +2,7 @@ "name": "com.unity.netcode.gameobjects", "displayName": "Netcode for GameObjects", "description": "Netcode for GameObjects is a high-level netcode SDK that provides networking capabilities to GameObject/MonoBehaviour workflows within Unity and sits on top of underlying transport layer.", - "version": "2.11.3", + "version": "3.0.0", "unity": "6000.0", "dependencies": { "com.unity.nuget.mono-cecil": "1.11.4", diff --git a/pvpExceptions.json b/pvpExceptions.json index 334f50cde3..fa8942ab76 100644 --- a/pvpExceptions.json +++ b/pvpExceptions.json @@ -7,17 +7,11 @@ }, "PVP-130-2": { "errors": [ - "Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.CodeGen", + "Editor/CodeGen/Unity.Netcode.CodeGen.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.CodeGen", "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.PackageChecker", "Editor/Unity.Netcode.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor", "Tests/Editor/Unity.Netcode.Editor.Tests.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.Tests" ] - }, - "PVP-132-2": { - "errors": [ - "Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef: name of editor assembly should end with '.Editor'", - "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: name of editor assembly should end with '.Editor'" - ] } } } From 5696b12390cf2fe13858141d9b5670a8a9f942d7 Mon Sep 17 00:00:00 2001 From: Emma Date: Fri, 15 May 2026 13:57:12 -0400 Subject: [PATCH 3/6] Update pvp exceptions --- pvpExceptions.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvpExceptions.json b/pvpExceptions.json index fa8942ab76..a705fbd2bc 100644 --- a/pvpExceptions.json +++ b/pvpExceptions.json @@ -8,7 +8,7 @@ "PVP-130-2": { "errors": [ "Editor/CodeGen/Unity.Netcode.CodeGen.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.CodeGen", - "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.PackageChecker", + "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.PackageChecker.Editor", "Editor/Unity.Netcode.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor", "Tests/Editor/Unity.Netcode.Editor.Tests.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.Tests" ] From 53e5dd35c88f9814e68e67a064dcff4fd85d636c Mon Sep 17 00:00:00 2001 From: Emma Date: Fri, 15 May 2026 14:10:34 -0400 Subject: [PATCH 4/6] fix codegen naming --- .../Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef | 2 +- pvpExceptions.json | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef b/com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef index 8f94aa0a7a..1b93c60458 100644 --- a/com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef +++ b/com.unity.netcode.gameobjects/Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef @@ -1,5 +1,5 @@ { - "name": "Unity.Netcode.GameObjects.CodeGen.Editor", + "name": "Unity.Netcode.GameObjects.Editor.CodeGen", "rootNamespace": "Unity.Netcode.GameObjects.Editor.CodeGen", "references": [ "Unity.Netcode.Runtime", diff --git a/pvpExceptions.json b/pvpExceptions.json index a705fbd2bc..de1c8a8ded 100644 --- a/pvpExceptions.json +++ b/pvpExceptions.json @@ -8,10 +8,15 @@ "PVP-130-2": { "errors": [ "Editor/CodeGen/Unity.Netcode.CodeGen.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.CodeGen", - "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.PackageChecker.Editor", + "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.PackageChecker", "Editor/Unity.Netcode.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor", "Tests/Editor/Unity.Netcode.Editor.Tests.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.Tests" ] + }, + "PVP-132-2": { + "errors": [ + "Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef: name of editor assembly should end with '.Editor'" + ] } } } From 731515e362a8ed4bc76568b59d7c2c8f02c9a475 Mon Sep 17 00:00:00 2001 From: Emma Date: Fri, 15 May 2026 14:12:15 -0400 Subject: [PATCH 5/6] Another try --- pvpExceptions.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvpExceptions.json b/pvpExceptions.json index de1c8a8ded..db6ac65feb 100644 --- a/pvpExceptions.json +++ b/pvpExceptions.json @@ -7,7 +7,7 @@ }, "PVP-130-2": { "errors": [ - "Editor/CodeGen/Unity.Netcode.CodeGen.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.CodeGen", + "Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.CodeGen", "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.PackageChecker", "Editor/Unity.Netcode.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor", "Tests/Editor/Unity.Netcode.Editor.Tests.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.Tests" From 115062aaaae2dced2973bbb7d7a4a00d54c69b9b Mon Sep 17 00:00:00 2001 From: Emma Date: Fri, 15 May 2026 14:16:35 -0400 Subject: [PATCH 6/6] Final try --- pvpExceptions.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvpExceptions.json b/pvpExceptions.json index db6ac65feb..c5bd307e4d 100644 --- a/pvpExceptions.json +++ b/pvpExceptions.json @@ -8,7 +8,7 @@ "PVP-130-2": { "errors": [ "Editor/CodeGen/Unity.Netcode.Editor.CodeGen.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.CodeGen", - "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.PackageChecker", + "Editor/PackageChecker/Unity.Netcode.PackageChecker.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.PackageChecker.Editor", "Editor/Unity.Netcode.Editor.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor", "Tests/Editor/Unity.Netcode.Editor.Tests.asmdef: assembly name does not match filename: Unity.Netcode.GameObjects.Editor.Tests" ]