MTTB-85: Removed the use of a foreach to stop a GC allocation

samlucas-unity · samlucas-unity · commit fc36e2a4abe3 · 2025-06-27T12:19:37.000+01:00
diff --git a/com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs b/com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs
@@ -1013,9 +1013,9 @@ private void ExtractNetworkMetrics()
         {
             if (m_NetworkManager.IsServer)
             {
-                var ngoConnectionIds = m_NetworkManager.ConnectedClients.Keys;
-                foreach (var ngoConnectionId in ngoConnectionIds)
+                for (int i=0; i<m_NetworkManager.ConnectedClientsIds.Count; ++i)
                 {
+                    var ngoConnectionId =  m_NetworkManager.ConnectedClientsIds[i];
                     if (ngoConnectionId == 0 && m_NetworkManager.IsHost)
                     {
                         continue;

Original file line number	Diff line number	Diff line change
`@@ -1013,9 +1013,9 @@ private void ExtractNetworkMetrics()`
`1013`	`1013`	`{`
`1014`	`1014`	`if (m_NetworkManager.IsServer)`
`1015`	`1015`	`{`
`1016`		`- var ngoConnectionIds = m_NetworkManager.ConnectedClients.Keys;`
`1017`		`- foreach (var ngoConnectionId in ngoConnectionIds)`
	`1016`	`+ for (int i=0; i<m_NetworkManager.ConnectedClientsIds.Count; ++i)`
`1018`	`1017`	`{`
	`1018`	`+ var ngoConnectionId = m_NetworkManager.ConnectedClientsIds[i];`
`1019`	`1019`	`if (ngoConnectionId == 0 && m_NetworkManager.IsHost)`
`1020`	`1020`	`{`
`1021`	`1021`	`continue;`