small fixes

Author: EmandM

com.unity.netcode.gameobjects/Documentation~/advanced-topics/message-system/rpc.md

@@ -1,6 +1,6 @@
 # RPC
 
-Any process can communicate with any other process by sending a remote procedure call (RPC). As of Netcode for GameObjects version 1.8.0, the `Rpc` attribute encompasses server to client RPCs, client to server RPCs, and client to client RPCs.
+Any process can communicate with any other process by sending a remote procedure call (RPC). The `Rpc` attribute is used to define who receives and executes the RPC.
 
 ![](../../images/sequence_diagrams/RPCs/ServerRPCs.png)
 

com.unity.netcode.gameobjects/Editor/CodeGen/NetworkBehaviourILPP.cs

@@ -612,7 +612,7 @@ private void CreateNetworkVariableTypeInitializers(AssemblyDefinition assembly,
         private const string k_RpcAttribute_InvokePermission = nameof(RpcAttribute.InvokePermission);
 
 #pragma warning disable CS0618 // Type or member is obsolete
-// Need to ignore the obsolete warning as the obsolete behaviour still needs to work
+        // Need to ignore the obsolete warning as the obsolete behaviour still needs to work
         private const string k_ServerRpcAttribute_RequireOwnership = nameof(ServerRpcAttribute.RequireOwnership);
 #pragma warning restore CS0618 // Type or member is obsolete
 

com.unity.netcode.gameobjects/Runtime/Messaging/RpcAttributes.cs

@@ -40,7 +40,8 @@ public enum RpcInvokePermission
     }
 
     /// <summary>
-    /// <para>Represents the common base class for Rpc attributes.</para>
+    /// <para>Marks a method as a remote procedure call (RPC).</para>
+    /// <para>The marked method will be executed on all game instances defined by the <see cref="SendTo"/> target.</para>
     /// </summary>
     [AttributeUsage(AttributeTargets.Method)]
     public class RpcAttribute : Attribute
@@ -80,7 +81,7 @@ public struct RpcAttributeParams
         public RpcDelivery Delivery = RpcDelivery.Reliable;
 
         /// <summary>
-        /// Who has network permission to invoke this RPC
+        /// Controls who has permission to invoke this RPC. The default setting is <see cref="RpcInvokePermission.Everyone"/>
         /// </summary>
         public RpcInvokePermission InvokePermission;
 
@@ -90,7 +91,7 @@ public struct RpcAttributeParams
         /// <remarks>
         /// Deprecated in favor of <see cref="InvokePermission"/>.
         /// </remarks>
-        [Obsolete("RequireOwnership is deprecated. Please use InvokePermission = RpcInvokePermission.Owner instead.")]
+        [Obsolete("RequireOwnership is deprecated. Please use InvokePermission = RpcInvokePermission.Owner or InvokePermission = RpcInvokePermission.Everyone instead.")]
         public bool RequireOwnership;
 
         /// <summary>
@@ -127,15 +128,14 @@ public class ServerRpcAttribute : RpcAttribute
     {
         /// <summary>
         /// When true, only the owner of the NetworkObject can invoke this ServerRpc.
-        /// This property sets the base <see cref="RpcAttribute.InvokePermission"/> to <see cref="RpcInvokePermission.Owner"/> when "RequireOwnership = true" or to  <see cref="RpcInvokePermission.Everyone"/> when "RequireOwnership = false". />.
         /// </summary>
         /// <remarks>
-        /// Deprecated in favor of using <see cref="RpcAttribute"/> with <see cref="SendTo.Server"/> and an <see cref="RpcAttribute.InvokePermission"/>.
+        /// <para> Deprecated in favor of using <see cref="RpcAttribute"/> with a <see cref="SendTo.Server"/> target and an <see cref="RpcAttribute.InvokePermission"/>.</para>
         /// <code>
         ///     [ServerRpc(RequireOwnership = false)]
         ///     // is replaced with
         ///     [Rpc(SendTo.Server, InvokePermission = RpcInvokePermission.Everyone)]
-        ///     // or, as InvokePermission has a default setting of RpcInvokePermission.Everyone, you can also use
+        ///     // as InvokePermission has a default setting of RpcInvokePermission.Everyone, you can also use
         ///     [Rpc(SendTo.Server)]
         /// </code>
         /// <code>

com.unity.netcode.gameobjects/Tests/Runtime/Rpc/RpcInvocationTests.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections;
 using System.Collections.Generic;
 using System.Runtime.CompilerServices;
@@ -13,11 +12,11 @@ namespace Unity.Netcode.RuntimeTests.Rpc
 {
     [TestFixture(NetworkTopologyTypes.DistributedAuthority)]
     [TestFixture(NetworkTopologyTypes.ClientServer)]
-    internal class RpcInvocationTests: NetcodeIntegrationTest
+    internal class RpcInvocationTests : NetcodeIntegrationTest
     {
         protected override int NumberOfClients => 3;
 
-        public RpcInvocationTests(NetworkTopologyTypes topologyType) : base(topologyType) {}
+        public RpcInvocationTests(NetworkTopologyTypes topologyType) : base(topologyType) { }
 
         private GameObject m_Prefab;
 

com.unity.netcode.gameobjects/Tests/Runtime/Rpc/RpcManyClientsTests.cs

@@ -127,7 +127,7 @@ public void RpcManyClientsTest()
 
             rpcManyClientsObject.ReceivedFrom.Clear();
             rpcManyClientsObject.Count = 0;
-            var target = new [] { m_ClientNetworkManagers[1].LocalClientId, m_ClientNetworkManagers[2].LocalClientId };
+            var target = new[] { m_ClientNetworkManagers[1].LocalClientId, m_ClientNetworkManagers[2].LocalClientId };
             param.Send.Target = rpcManyClientsObject.RpcTarget.Group(target, RpcTargetUse.Temp);
             rpcManyClientsObject.WithParamsClientRpc(param);