fix & update

Fixing test project not being able to load without an AnalyticsTests compilation error.
Making ObjectNameIdentifier just use the new way we handle ChildNetworkBehaviours (i.e. it is a table now).
Marking NetworkObject.ChildNetworkBehaviours comment above as having finished the migration to a table.
Noting we should find a better place/way to initialize this stuff.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -2816,11 +2816,13 @@ private NetworkPrefab GetPrefab(NetworkManager networkManager)
         /// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
         /// Convert ChildNetworkBehaviours to a
         /// table so removing won't impact things.
+        /// (Done)
+        ///
+        /// Find a place to do this initialization
+        /// somewhere else so we don't have a 
+        /// megalithic getter.
         /// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
         /// </summary>
-
-
-
         internal Dictionary<ushort, NetworkBehaviour> ChildNetworkBehaviours
         {
             get

com.unity.netcode.gameobjects/Tests/Runtime/TestHelpers/Components/ObjectNameIdentifier.cs

@@ -108,17 +108,10 @@ public override void OnDestroy()
                 DeRegisterNetworkObject();
                 // This is required otherwise it will try to continue to update the NetworkBehaviour even if
                 // it has been destroyed (most likely integration test specific)
-#if UNIFIED_NETCODE
                 if (m_NetworkObject.ChildNetworkBehaviours != null && m_NetworkObject.ChildNetworkBehaviours.ContainsKey(NetworkBehaviourId))
                 {
                     NetworkObject.ChildNetworkBehaviours.Remove(NetworkBehaviourId);
                 }
-#else
-                if (m_NetworkObject.ChildNetworkBehaviours != null && m_NetworkObject.ChildNetworkBehaviours.Contains(this))
-                {
-                    NetworkObject.ChildNetworkBehaviours.Remove(this);
-                }
-#endif
                 m_NetworkObject = null;
             }
             base.OnDestroy();

testproject/Assets/Tests/Runtime/AnalyticsTests.cs

@@ -22,7 +22,7 @@ internal class AnalyticsTests : NetcodeIntegrationTest
         protected override IEnumerator OnSetup()
         {
             NetcodeAnalytics.EnableIntegrationTestAnalytics = true;
-            m_NetcodeAnalytics = Unity.Netcode.Editor.NetworkManagerHelper.Singleton.NetcodeAnalytics;
+            m_NetcodeAnalytics = Unity.Netcode.GameObjects.Editor.NetworkManagerHelper.Singleton.NetcodeAnalytics;
             yield return base.OnSetup();
         }
 

testproject/Assets/Tests/Runtime/TestProject.Runtime.Tests.asmdef

@@ -15,7 +15,8 @@
         "Unity.Mathematics",
         "UnityEngine.TestRunner",
         "UnityEditor.TestRunner",
-        "Unity.Netcode.Runtime.Tests"
+        "Unity.Netcode.Runtime.Tests",
+        "Unity.Netcode.GameObjects.Editor"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],