test

Some more instability related fixes.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Tests/Runtime/AttachableBehaviourTests.cs

@@ -118,7 +118,7 @@ private bool ResetAllStates()
                 else
                 {
                     var attachable = networkManager.SpawnManager.SpawnedObjects[currentAttachableRoot.NetworkObjectId].GetComponentInChildren<TestAttachable>();
-                    attachable.ResetStates();
+                    attachable?.ResetStates();
                 }
 
                 // Target
@@ -129,7 +129,7 @@ private bool ResetAllStates()
                 else
                 {
                     var node = networkManager.SpawnManager.SpawnedObjects[m_TargetInstance.NetworkObjectId].GetComponentInChildren<TestNode>();
-                    node.ResetStates();
+                    node?.ResetStates();
                 }
 
                 // Target B
@@ -140,7 +140,7 @@ private bool ResetAllStates()
                 else
                 {
                     var node = networkManager.SpawnManager.SpawnedObjects[m_TargetInstanceB.NetworkObjectId].GetComponentInChildren<TestNode>();
-                    node.ResetStates();
+                    node?.ResetStates();
                 }
             }
             return m_ErrorLog.Length == 0;

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/OwnerPermissionTests.cs

@@ -110,16 +110,10 @@ public IEnumerator OwnerPermissionTest()
                 {
                     ownerManager = m_ClientNetworkManagers[objectIndex - 1];
                 }
-                SpawnObject(m_PrefabToSpawn, ownerManager);
+                var spawnedInstance = SpawnObject(m_PrefabToSpawn, ownerManager);
 
-                // wait for each object to spawn on each client
-                for (var clientIndex = 0; clientIndex < 3; clientIndex++)
-                {
-                    while (OwnerPermissionObject.Objects[objectIndex, clientIndex] == null)
-                    {
-                        yield return new WaitForSeconds(0.0f);
-                    }
-                }
+                yield return WaitForSpawnedOnAllOrTimeOut(spawnedInstance);
+                AssertOnTimeout($"Timed out waiting for all clients to spawn {spawnedInstance.name}!");
             }
 
             var nextValueToWrite = 1;