Addressing PR feedback

Author: noellie-velez

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -14,10 +14,6 @@ Additional documentation and release notes are available at [Multiplayer Documen
 ### Changed
 
 - Improve performance of `NetworkObject`. (#3820)
-- Rename pass:
-    - SceneObject -- > SerializedObject
-    - GetMessageSceneObject --> Serialize
-    - AddSceneObject --> Deserialize (#3820)
 
 ### Deprecated
 

com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ConnectionApprovedMessage.cs

@@ -160,8 +160,8 @@ public void Serialize(FastBufferWriter writer, int targetVersion)
                     {
                         sobj.Observers.Add(OwnerClientId);
                         // In distributed authority mode, we send the currently known observers of each NetworkObject to the client being synchronized.
-                        var sceneObject = sobj.Serialize(OwnerClientId, IsDistributedAuthority);
-                        sceneObject.Serialize(writer);
+                        var serializedObject = sobj.Serialize(OwnerClientId, IsDistributedAuthority);
+                        serializedObject.Serialize(writer);
                         ++sceneObjectCount;
                     }
                 }
@@ -342,9 +342,9 @@ public void Handle(ref NetworkContext context)
                 // to create a list to hold the data. This is a breach of convention for performance reasons.
                 for (ushort i = 0; i < sceneObjectCount; i++)
                 {
-                    var sceneObject = new NetworkObject.SerializedObject();
-                    sceneObject.Deserialize(m_ReceivedSceneObjectData);
-                    NetworkObject.Deserialize(sceneObject, m_ReceivedSceneObjectData, networkManager);
+                    var serializedObject = new NetworkObject.SerializedObject();
+                    serializedObject.Deserialize(m_ReceivedSceneObjectData);
+                    NetworkObject.Deserialize(serializedObject, m_ReceivedSceneObjectData, networkManager);
                 }
 
                 if (networkManager.AutoSpawnPlayerPrefabClientSide)

com.unity.netcode.gameobjects/Runtime/Messaging/Messages/ParentSyncMessage.cs

@@ -38,6 +38,7 @@ internal struct ParentSyncMessage : INetworkMessage
 
         public void Serialize(FastBufferWriter writer, int targetVersion)
         {
+
             byte bitset = 0x00;
             if (WorldPositionStays) { bitset |= k_WorldPositionStays; }
             if (IsLatestParentSet) { bitset |= k_IsLatestParentSet; }

com.unity.netcode.gameobjects/Runtime/SceneManagement/SceneEventData.cs

@@ -625,9 +625,9 @@ internal void WriteSceneSynchronizationData(FastBufferWriter writer)
                 var networkObject = m_NetworkObjectsSync[i];
                 var noStart = writer.Position;
                 // In distributed authority mode, we send the currently known observers of each NetworkObject to the client being synchronized.
-                var sceneObject = m_NetworkObjectsSync[i].Serialize(TargetClientId, distributedAuthority);
+                var serializedObject = m_NetworkObjectsSync[i].Serialize(TargetClientId, distributedAuthority);
 
-                sceneObject.Serialize(writer);
+                serializedObject.Serialize(writer);
                 var noStop = writer.Position;
                 totalBytes += noStop - noStart;
                 if (EnableSerializationLogs)
@@ -705,8 +705,8 @@ internal void SerializeScenePlacedObjects(FastBufferWriter writer)
             foreach (var objectToSycn in m_NetworkObjectsSync)
             {
                 // Serialize the NetworkObject
-                var sceneObject = objectToSycn.Serialize(TargetClientId, distributedAuthority);
-                sceneObject.Serialize(writer);
+                var serializedObject = objectToSycn.Serialize(TargetClientId, distributedAuthority);
+                serializedObject.Serialize(writer);
                 numberOfObjects++;
             }
 
@@ -871,18 +871,18 @@ internal void DeserializeScenePlacedObjects()
                 var sceneObjects = new List<NetworkObject>();
                 for (ushort i = 0; i < newObjectsCount; i++)
                 {
-                    var sceneObject = new NetworkObject.SerializedObject();
-                    sceneObject.Deserialize(InternalBuffer);
+                    var serializedObject = new NetworkObject.SerializedObject();
+                    serializedObject.Deserialize(InternalBuffer);
 
-                    if (sceneObject.IsSceneObject)
+                    if (serializedObject.IsSceneObject)
                     {
                         // Set our relative scene to the NetworkObject
-                        m_NetworkManager.SceneManager.SetTheSceneBeingSynchronized(sceneObject.NetworkSceneHandle);
+                        m_NetworkManager.SceneManager.SetTheSceneBeingSynchronized(serializedObject.NetworkSceneHandle);
                     }
 
-                    var networkObject = NetworkObject.Deserialize(sceneObject, InternalBuffer, m_NetworkManager);
+                    var networkObject = NetworkObject.Deserialize(serializedObject, InternalBuffer, m_NetworkManager);
 
-                    if (sceneObject.IsSceneObject)
+                    if (serializedObject.IsSceneObject)
                     {
                         sceneObjects.Add(networkObject);
                     }
@@ -1136,15 +1136,15 @@ internal void SynchronizeSceneNetworkObjects(NetworkManager networkManager)
                 for (int i = 0; i < newObjectsCount; i++)
                 {
                     var noStart = InternalBuffer.Position;
-                    var sceneObject = new NetworkObject.SerializedObject();
-                    sceneObject.Deserialize(InternalBuffer);
+                    var serializedObject = new NetworkObject.SerializedObject();
+                    serializedObject.Deserialize(InternalBuffer);
 
                     // If the sceneObject is in-scene placed, then set the scene being synchronized
-                    if (sceneObject.IsSceneObject)
+                    if (serializedObject.IsSceneObject)
                     {
-                        m_NetworkManager.SceneManager.SetTheSceneBeingSynchronized(sceneObject.NetworkSceneHandle);
+                        m_NetworkManager.SceneManager.SetTheSceneBeingSynchronized(serializedObject.NetworkSceneHandle);
                     }
-                    var spawnedNetworkObject = NetworkObject.Deserialize(sceneObject, InternalBuffer, networkManager);
+                    var spawnedNetworkObject = NetworkObject.Deserialize(serializedObject, InternalBuffer, networkManager);
 
                     var noStop = InternalBuffer.Position;
                     if (EnableSerializationLogs)