chore: making NetworkTransform's interpolation bounds configurable. (#1979)

* chore: making NetworkTransform's interpolation bounds configurable.
Fixes an intermittent test breakage due to extrapolation bringing us out-of-bounds

* style: coding standard adjustments

Author: jeffreyrainy

com.unity.netcode.gameobjects/Components/Interpolator/BufferedLinearInterpolator.cs

@@ -10,6 +10,7 @@ namespace Unity.Netcode
     /// </summary>
     public abstract class BufferedLinearInterpolator<T> where T : struct
     {
+        internal float MaxInterpolationBound = 3.0f;
         private struct BufferedItem
         {
             public T Item;
@@ -203,10 +204,9 @@ public T Update(float deltaTime, double renderTime, double serverTime)
                         t = 0.0f;
                     }
 
-                    if (t > 3.0f) // max extrapolation
+                    if (t > MaxInterpolationBound) // max extrapolation
                     {
                         // TODO this causes issues with teleport, investigate
-                        // todo make this configurable
                         t = 1.0f;
                     }
                 }

com.unity.netcode.gameobjects/Components/NetworkTransform.cs

@@ -720,6 +720,17 @@ private void OnNetworkStateChanged(NetworkTransformState oldState, NetworkTransf
             }
         }
 
+        public void SetMaxInterpolationBound(float maxInterpolationBound)
+        {
+            m_PositionXInterpolator.MaxInterpolationBound = maxInterpolationBound;
+            m_PositionYInterpolator.MaxInterpolationBound = maxInterpolationBound;
+            m_PositionZInterpolator.MaxInterpolationBound = maxInterpolationBound;
+            m_RotationInterpolator.MaxInterpolationBound = maxInterpolationBound;
+            m_ScaleXInterpolator.MaxInterpolationBound = maxInterpolationBound;
+            m_ScaleYInterpolator.MaxInterpolationBound = maxInterpolationBound;
+            m_ScaleZInterpolator.MaxInterpolationBound = maxInterpolationBound;
+        }
+
         private void Awake()
         {
             // we only want to create our interpolators during Awake so that, when pooled, we do not create tons

com.unity.netcode.gameobjects/Tests/Runtime/TransformInterpolationTests.cs

@@ -33,11 +33,7 @@ private void Update()
             // Move the nested object on the server
             if (IsMoving)
             {
-                var y = Time.realtimeSinceStartup;
-                while (y > 10.0f)
-                {
-                    y -= 10.0f;
-                }
+                var y = Time.realtimeSinceStartup % 10.0f;
 
                 // change the space between local and global every second
                 GetComponent<NetworkTransform>().InLocalSpace = ((int)y % 2 == 0);
@@ -119,6 +115,7 @@ public IEnumerator TransformInterpolationTest()
 
             baseObject.GetComponent<TransformInterpolationObject>().IsFixed = true;
             spawnedObject.GetComponent<TransformInterpolationObject>().IsMoving = true;
+            spawnedObject.GetComponent<NetworkTransform>().SetMaxInterpolationBound(1.0f);
 
             const float maxPlacementError = 0.01f;
 
@@ -131,6 +128,7 @@ public IEnumerator TransformInterpolationTest()
                 yield return new WaitForSeconds(0.01f);
             }
 
+            m_SpawnedObjectOnClient.GetComponent<NetworkTransform>().SetMaxInterpolationBound(1.0f);
             m_SpawnedObjectOnClient.GetComponent<TransformInterpolationObject>().CheckPosition = true;
 
             // Test that interpolation works correctly for 10 seconds