Apply suggestions from code review

EmandM · NoelStephensUnity · web-flow · commit 85785bcded07 · 2025-11-03T12:17:57.000-05:00
Co-authored-by: Noel Stephens &lt;noel.stephens@unity3d.com&gt;
diff --git a/com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs b/com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
@@ -846,7 +846,7 @@ public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReade
             }
 
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
-            public void SerializeBitset(ref FastBufferWriter writer)
+            internal void SerializeBitset(ref FastBufferWriter writer)
             {
                 uint bitset = 0;
 
@@ -879,7 +879,7 @@ public void SerializeBitset(ref FastBufferWriter writer)
             }
 
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
-            public void DeserializeBitset(ref FastBufferReader reader)
+            internal void DeserializeBitset(ref FastBufferReader reader)
             {
                 ByteUnpacker.ReadValueBitPacked(reader, out uint bitset);
 
diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/TestHelpers/NUnitExtensions/IgnoreIfServiceEnvironmentVariableSetAttribute.cs b/com.unity.netcode.gameobjects/Tests/Runtime/TestHelpers/NUnitExtensions/IgnoreIfServiceEnvironmentVariableSetAttribute.cs
@@ -6,7 +6,7 @@
 namespace Unity.Netcode.TestHelpers.Runtime
 {
     [AttributeUsage(AttributeTargets.Class, AllowMultiple = false, Inherited = true)]
-    public class IgnoreIfServiceEnvironmentVariableSetAttribute : NUnitAttribute, IApplyToTest
+    internal class IgnoreIfServiceEnvironmentVariableSetAttribute : NUnitAttribute, IApplyToTest
     {
         public void ApplyToTest(Test test)
         {

Original file line number	Diff line number	Diff line change
`@@ -846,7 +846,7 @@ public void NetworkSerialize<T>(BufferSerializer<T> serializer) where T : IReade`
`846`	`846`	`}`
`847`	`847`
`848`	`848`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`849`		`- public void SerializeBitset(ref FastBufferWriter writer)`
	`849`	`+ internal void SerializeBitset(ref FastBufferWriter writer)`
`850`	`850`	`{`
`851`	`851`	`uint bitset = 0;`
`852`	`852`
`@@ -879,7 +879,7 @@ public void SerializeBitset(ref FastBufferWriter writer)`
`879`	`879`	`}`
`880`	`880`
`881`	`881`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`882`		`- public void DeserializeBitset(ref FastBufferReader reader)`
	`882`	`+ internal void DeserializeBitset(ref FastBufferReader reader)`
`883`	`883`	`{`
`884`	`884`	`ByteUnpacker.ReadValueBitPacked(reader, out uint bitset);`
`885`	`885`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Unity.Netcode.TestHelpers.Runtime`
`7`	`7`	`{`
`8`	`8`	`[AttributeUsage(AttributeTargets.Class, AllowMultiple = false, Inherited = true)]`
`9`		`- public class IgnoreIfServiceEnvironmentVariableSetAttribute : NUnitAttribute, IApplyToTest`
	`9`	`+ internal class IgnoreIfServiceEnvironmentVariableSetAttribute : NUnitAttribute, IApplyToTest`
`10`	`10`	`{`
`11`	`11`	`public void ApplyToTest(Test test)`
`12`	`12`	`{`