remove uninitialized from list instead of ignoring

Author: larus

com.unity.netcode.gameobjects/Runtime/Configuration/NetworkPrefabs.cs

@@ -81,10 +81,6 @@ internal void Shutdown()
         {
             foreach (var list in NetworkPrefabsLists)
             {
-                if (list == null)
-                {
-                    continue;
-                }
                 list.OnAdd -= AddTriggeredByNetworkPrefabList;
                 list.OnRemove -= RemoveTriggeredByNetworkPrefabList;
             }
@@ -98,12 +94,9 @@ internal void Shutdown()
         public void Initialize(bool warnInvalid = true)
         {
             m_Prefabs.Clear();
+            NetworkPrefabsLists.RemoveAll(x => x == null);
             foreach (var list in NetworkPrefabsLists)
             {
-                if (list == null)
-                {
-                    continue;
-                }
                 list.OnAdd += AddTriggeredByNetworkPrefabList;
                 list.OnRemove += RemoveTriggeredByNetworkPrefabList;
             }
@@ -117,10 +110,6 @@ public void Initialize(bool warnInvalid = true)
             {
                 foreach (var list in NetworkPrefabsLists)
                 {
-                    if (list == null)
-                    {
-                        continue;
-                    }
                     prefabs.AddRange(list.PrefabList);
                 }
             }

com.unity.netcode.gameobjects/Tests/Editor/NetworkManagerConfigurationTests.cs

@@ -303,8 +303,8 @@ public void WhenThereAreUninitializedElementsInPrefabsList_NoErrors()
 
             networkConfig.InitializePrefabs();
 
-            Assert.IsTrue(networkConfig.Prefabs.NetworkPrefabsLists.Count == 1);
-            Assert.IsTrue(networkConfig.Prefabs.NetworkPrefabsLists[0] == null);
+            // Null elements will be removed from the list so it should be empty
+            Assert.IsTrue(networkConfig.Prefabs.NetworkPrefabsLists.Count == 0);
             Assert.IsTrue(networkConfig.Prefabs.Prefabs.Count == 0);
 
             networkConfig.Prefabs.Shutdown();