Fix some tests

Author: EmandM

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -1171,14 +1171,7 @@ private bool InternalHasAuthority()
         /// <summary>
         /// Gets if the object is owned by the local player or if the object is the local player object
         /// </summary>
-        public bool IsOwner
-        {
-            get
-            {
-                Debug.Log($"[Client-{NetworkManager.LocalClientId}][Object-{NetworkObjectId}] Owned by {OwnerClientId}");
-                return NetworkManager != null && OwnerClientId == NetworkManager.LocalClientId;
-            }
-        }
+        public bool IsOwner => NetworkManager != null && OwnerClientId == NetworkManager.LocalClientId;
 
         /// <summary>
         /// Gets Whether or not the object is owned by anyone
@@ -2224,12 +2217,12 @@ public bool TrySetParent(NetworkObject parent, bool worldPositionStays = true)
             // DANGO-TODO: Do we want to worry about ownership permissions here?
             // It wouldn't make sense to not allow parenting, but keeping this note here as a reminder.
             var isAuthority = HasAuthority || (AllowOwnerToParent && IsOwner);
+            Debug.Log($"something is broken! isAuthority={isAuthority} | HasAuthority={HasAuthority} | (AllowOwnerToParent && IsOwner)={(AllowOwnerToParent && IsOwner)}");
 
             // If we don't have authority and we are not shutting down, then don't allow any parenting.
             // If we are shutting down and don't have authority then allow it.
             if (!isAuthority && !NetworkManager.ShutdownInProgress)
             {
-                Debug.LogError("We don't have authority here");
                 return false;
             }
 
@@ -2293,7 +2286,6 @@ private void OnTransformParentChanged()
             // With distributed authority, we need to track "valid authoritative" parenting changes.
             // So, either the authority or AuthorityAppliedParenting is considered a "valid parenting change".
             isAuthority = HasAuthority || AuthorityAppliedParenting || (AllowOwnerToParent && IsOwner);
-            Debug.Log($"[Client-{NetworkManager.LocalClientId}][Object-{NetworkObjectId}] OnTransformParentChanged. HasAuthority={HasAuthority}, AuthorityAppliedParenting={AuthorityAppliedParenting}, AllowOwnerToParent && IsOwner={AllowOwnerToParent && IsOwner}");
             var distributedAuthority = NetworkManager.DistributedAuthorityMode;
 
             // If we do not have authority and we are spawned
@@ -2364,8 +2356,6 @@ private void OnTransformParentChanged()
             var authorityApplied = AuthorityAppliedParenting;
             ApplyNetworkParenting(removeParent);
 
-
-
             var message = new ParentSyncMessage
             {
                 NetworkObjectId = NetworkObjectId,

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformOrderOfOperations.cs

@@ -178,7 +178,7 @@ public IEnumerator OrderOfOperations()
             var parent1 = m_AuthorityParentInstances[0];
             var parent2 = m_AuthorityParentInstances[1];
 
-            ConfigureSequencesTest1(parent1);
+            ConfigureSequencesTest1_ClientServerOnly(parent1);
             yield return RunTestSequences();
 
             ConfigureSequencesTest2(parent1);
@@ -293,12 +293,19 @@ private IEnumerator __RunTestSequences(bool spawnWithObservers = true, bool spaw
 
         #region Test Sequence Configurations
         /// <summary>
+        /// Client server only - under da mode only the authority can parent
         /// Test-1:
         /// Authority-> Spawn, change ownership, (wait), parent
         /// </summary>
-        private void ConfigureSequencesTest1(NetworkObject parent)
+        private void ConfigureSequencesTest1_ClientServerOnly(NetworkObject parent)
         {
-            SpawnSequenceController.CurrentTest = "Test1";
+            SpawnSequenceController.CurrentTest = "Test1 (Client-Server Only)";
+            if (m_AuthorityNetworkManager.DistributedAuthorityMode)
+            {
+                SpawnSequenceController.ClientServerOnly = true;
+                return;
+            }
+
             var changeOwnershipSequence = new ChangeOwnershipSequence()
             {
                 Stage = SpawnSequence.SpawnStage.AfterSpawn,
@@ -310,6 +317,7 @@ private void ConfigureSequencesTest1(NetworkObject parent)
                 TimeDelayInMS = 200,
                 Stage = SpawnSequence.SpawnStage.AfterSpawn,
                 TargetParent = parent,
+                InvokeOnlyOnClientId = GetAuthorityNetworkManager().LocalClientId,
             };
 
             SpawnSequenceController.AddAction(changeOwnershipSequence);
@@ -860,6 +868,10 @@ protected override bool OnShouldInvoke(SpawnStage stage)
             protected override void OnAction()
             {
                 m_NetworkObject.ChangeOwnership(TargetOwnerClientId);
+                if (TargetOwnerClientId != m_NetworkObject.OwnerClientId)
+                {
+                    Debug.LogError($"[{m_NetworkObject.name}] Failed to change ownership!");
+                }
                 base.OnAction();
             }
         }
@@ -871,7 +883,20 @@ internal class ParentSequence : SpawnSequence
 
             protected override bool OnShouldInvoke(SpawnStage stage)
             {
-                return base.OnShouldInvoke(stage) && (m_NetworkObject.HasAuthority || (m_NetworkObject.IsOwner && m_NetworkObject.AllowOwnerToParent));
+                // Don't invoke if the base says no
+                if (!base.OnShouldInvoke(stage))
+                {
+                    return false;
+                }
+
+                // If sequence is configured to specifically invoke on this client
+                if (InvokeOnlyOnClientId.HasValue && m_NetworkObject.NetworkManager.LocalClientId == InvokeOnlyOnClientId.Value)
+                {
+                    return true;
+                }
+
+                // Otherwise we should invoke if we have the authority to invoke
+                return m_NetworkObject.HasAuthority || (m_NetworkObject.IsOwner && m_NetworkObject.AllowOwnerToParent);
             }
 
             protected override void OnAction()