fix

Use the GameObject.activeInHierarchy fix.
Allow disabled NetworkBehaviour with a disabled GameObject to internally start pre-spawn but exit before invoking protected method.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs

@@ -761,6 +761,13 @@ internal void NetworkPreSpawn(ref NetworkManager networkManager, NetworkObject n
 
             UpdateNetworkProperties();
 
+            // Exit early for disabled NetworkBehaviours.
+            // We still want the above values to be set.
+            if (!gameObject.activeInHierarchy)
+            {
+                return;
+            }
+
             try
             {
                 OnNetworkPreSpawn(ref networkManager);

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -2082,6 +2082,12 @@ internal void InvokeBehaviourOnNetworkObjectParentChanged(NetworkObject parentNe
         {
             for (int i = 0; i < ChildNetworkBehaviours.Count; i++)
             {
+                // Any NetworkBehaviour that is not spawned and the associated GameObject is disabled should be
+                // skipped over (i.e. not supported).
+                if (!ChildNetworkBehaviours[i].IsSpawned && !ChildNetworkBehaviours[i].gameObject.activeInHierarchy)
+                {
+                    continue;
+                }
                 // Invoke internal notification
                 ChildNetworkBehaviours[i].InternalOnNetworkObjectParentChanged(parentNetworkObject);
                 // Invoke public notification
@@ -2217,7 +2223,6 @@ public bool TrySetParent(NetworkObject parent, bool worldPositionStays = true)
             // DANGO-TODO: Do we want to worry about ownership permissions here?
             // It wouldn't make sense to not allow parenting, but keeping this note here as a reminder.
             var isAuthority = HasAuthority || (AllowOwnerToParent && IsOwner);
-            Debug.Log($"something is broken! isAuthority={isAuthority} | HasAuthority={HasAuthority} | (AllowOwnerToParent && IsOwner)={(AllowOwnerToParent && IsOwner)}");
 
             // If we don't have authority and we are not shutting down, then don't allow any parenting.
             // If we are shutting down and don't have authority then allow it.
@@ -2543,10 +2548,7 @@ internal void InvokeBehaviourNetworkPreSpawn()
             var networkManager = NetworkManager;
             for (int i = 0; i < ChildNetworkBehaviours.Count; i++)
             {
-                if (ChildNetworkBehaviours[i].gameObject.activeInHierarchy)
-                {
-                    ChildNetworkBehaviours[i].NetworkPreSpawn(ref networkManager, this);
-                }
+                ChildNetworkBehaviours[i].NetworkPreSpawn(ref networkManager, this);
             }
         }
 
@@ -2558,10 +2560,9 @@ internal void InvokeBehaviourNetworkSpawn()
             {
                 if (!childBehaviour.gameObject.activeInHierarchy)
                 {
-                    Debug.LogWarning($"{childBehaviour.gameObject.name} is disabled! Netcode for GameObjects does not support spawning disabled NetworkBehaviours! The {childBehaviour.GetType().Name} component was skipped during spawn!");
+                    Debug.LogWarning($"{GenerateDisabledNetworkBehaviourWarning(childBehaviour)}");
                     continue;
                 }
-
                 childBehaviour.InternalOnNetworkSpawn();
             }
         }
@@ -2621,7 +2622,7 @@ internal void InvokeBehaviourNetworkDespawn()
 
         internal string GenerateDisabledNetworkBehaviourWarning(NetworkBehaviour networkBehaviour)
         {
-            return $"[{name}][{networkBehaviour.GetType().Name}][{nameof(isActiveAndEnabled)}: {networkBehaviour.isActiveAndEnabled}] Disabled {nameof(NetworkBehaviour)}s are not supported and will be excluded from spawning and synchronization!";
+            return $"[{name}][{networkBehaviour.GetType().Name}][{nameof(isActiveAndEnabled)}: {networkBehaviour.isActiveAndEnabled}] Disabled {nameof(NetworkBehaviour)}s will be excluded from spawning and synchronization!";
         }
 
         internal List<NetworkBehaviour> ChildNetworkBehaviours
@@ -2644,11 +2645,6 @@ internal List<NetworkBehaviour> ChildNetworkBehaviours
                     {
                         continue;
                     }
-                    else if (!networkBehaviours[i].isActiveAndEnabled)
-                    {
-                        Debug.LogWarning(GenerateDisabledNetworkBehaviourWarning(networkBehaviours[i]));
-                        continue;
-                    }
 
                     // Set ourselves as the NetworkObject that this behaviour belongs to and add it to the child list
                     var nextIndex = (ushort)m_ChildNetworkBehaviours.Count;