test - fix

Resolving the PeerDisconnectCallbackTests instability where sometimes the disconnect notification is processed prior to the targeted client's NetworkManager having completely disconnected and shutdown (this would only have a chance of happening if server disconnects the client).

Hoping to resolve the instability with the ParentingInSceneObjectsTests resulting in a false failure.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Tests/Runtime/PeerDisconnectCallbackTests.cs

@@ -83,9 +83,21 @@ private void OnConnectionEventCallback(NetworkManager networkManager, Connection
             }
         }
 
+        private bool m_TargetClientShutdown;
+        private NetworkManager m_TargetClient;
+
+        private void ClientToDisconnect_OnClientStopped(bool wasHost)
+        {
+            m_TargetClient.OnClientStopped -= ClientToDisconnect_OnClientStopped;
+            m_TargetClientShutdown = true;
+        }
+
         [UnityTest]
         public IEnumerator TestPeerDisconnectCallback([Values] ClientDisconnectType clientDisconnectType, [Values(1ul, 2ul, 3ul)] ulong disconnectedClient)
         {
+            m_TargetClientShutdown = false;
+            m_TargetClient = m_ClientNetworkManagers[disconnectedClient - 1];
+            m_TargetClient.OnClientStopped += ClientToDisconnect_OnClientStopped;
             foreach (var client in m_ClientNetworkManagers)
             {
                 client.OnConnectionEvent += OnConnectionEventCallback;
@@ -129,12 +141,15 @@ public IEnumerator TestPeerDisconnectCallback([Values] ClientDisconnectType clie
             }
             else
             {
-                yield return StopOneClient(m_ClientNetworkManagers[disconnectedClient - 1]);
+                yield return StopOneClient(m_TargetClient);
             }
 
             yield return WaitForConditionOrTimeOut(hooks);
+            AssertOnTimeout($"Timed out waiting for all clients to receive the {nameof(ClientDisconnectedMessage)}!");
 
-            Assert.False(s_GlobalTimeoutHelper.TimedOut);
+            // Make sure the target client is shutdown before performing validation
+            yield return WaitForConditionOrTimeOut(() => m_TargetClientShutdown);
+            AssertOnTimeout($"Timed out waiting for {m_TargetClient.name} to shutdown!");
 
             foreach (var client in m_ClientNetworkManagers)
             {
@@ -182,5 +197,6 @@ public IEnumerator TestPeerDisconnectCallback([Values] ClientDisconnectType clie
             // Host receives peer disconnect, dedicated server does not
             Assert.AreEqual(m_UseHost ? 3 : 2, m_PeerDisconnectCount);
         }
+
     }
 }

testproject/Assets/Tests/Runtime/ObjectParenting/ParentingInSceneObjectsTests.cs

@@ -332,21 +332,21 @@ public IEnumerator InSceneParentingTest([Values] ParentingSpace parentingSpace)
             {
                 InSceneParentChildHandler.AuthorityRootParent.DeparentSetValuesAndReparent();
 
-                yield return WaitForConditionOrTimeOut(ValidateClientsAgainstAuthorityTransformValues);
+                yield return WaitForConditionOrTimeOut(() => ValidateAllChildrenParentingStatus(true));
                 if (s_GlobalTimeoutHelper.TimedOut)
                 {
                     InSceneParentChildHandler.AuthorityRootParent.CheckChildren();
                     yield return debugWait;
                 }
-                AssertOnTimeout($"[Final Pass][Deparent-Reparent-{i}] Timed out waiting for all clients transform values to match the server transform values!\n {m_ErrorValidationLog}");
+                AssertOnTimeout($"[Final Pass][Deparent-Reparent-{i}] Timed out waiting for all children to be removed from their parent!\n {m_ErrorValidationLog}");
 
-                yield return WaitForConditionOrTimeOut(() => ValidateAllChildrenParentingStatus(true));
+                yield return WaitForConditionOrTimeOut(ValidateClientsAgainstAuthorityTransformValues);
                 if (s_GlobalTimeoutHelper.TimedOut)
                 {
                     InSceneParentChildHandler.AuthorityRootParent.CheckChildren();
                     yield return debugWait;
                 }
-                AssertOnTimeout($"[Final Pass][Deparent-Reparent-{i}] Timed out waiting for all children to be removed from their parent!\n {m_ErrorValidationLog}");
+                AssertOnTimeout($"[Final Pass][Deparent-Reparent-{i}] Timed out waiting for all clients transform values to match the server transform values!\n {m_ErrorValidationLog}");
             }
 
             // In the final pass, we remove the second generation nested child