update

Temporary fix for missed sync.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -348,6 +348,11 @@ public void NetworkUpdate(NetworkUpdateStage updateStage)
                         {
                             NetworkConfig.Prefabs.RegisterGhostPrefabs(this);
                         }
+
+                        if (!IsServer)
+                        {
+                            SpawnManager?.CheckGhostsPendingNetworkObjectId();
+                        }
 #endif
 
                         UpdateTopology();

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -3854,13 +3854,27 @@ private void InitGhost()
             }
         }
 
-        private void RegisterGhostBridge()
+        internal bool IsGhostNetworkObjectIdValid()
+        {
+            if (NetworkObjectBridge == null)
+            {
+                return false;
+            }
+            // TODO-UNIFIED: Sometimes the GhostField can be latent. Need a way to know the GhostField has been set.
+            return NetworkObjectBridge.NetworkObjectId.Value < 1000000;
+        }
+
+        internal void RegisterGhostBridge()
         {
             if (NetworkManager.LogLevel == LogLevel.Developer)
             {
                 Debug.Log($"[{nameof(NetworkObject)}][{nameof(NetworkObjectId)}] NetworkObjectBridge notified instance exists with assigned ID of: {NetworkObjectBridge.NetworkObjectId.Value}");
             }
-            NetworkManager.SpawnManager.RegisterGhostPendingSpawn(this, NetworkObjectBridge.NetworkObjectId.Value);
+
+            if (!NetworkManager.IsServer)
+            {
+                NetworkManager.SpawnManager.RegisterGhostPendingSpawn(this, NetworkObjectBridge.NetworkObjectId.Value);
+            }
         }
 
         private void OnNetworkObjectIdChanged(ulong networkObjectId)

com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs

@@ -34,22 +34,59 @@ public class NetworkSpawnManager
 
         internal readonly Dictionary<ulong, NetworkObject> GhostsPendingSpawn = new Dictionary<ulong, NetworkObject>();
 
-        public void RegisterGhostPendingSpawn(NetworkObject networkObject, ulong networkObjectId)
+        internal readonly List<NetworkObject> GhostsPendingNetworkObjectId = new List<NetworkObject>();
+
+        internal void CheckGhostsPendingNetworkObjectId()
+        {
+            if (GhostsPendingNetworkObjectId.Count == 0)
+            {
+                return;
+            }
+
+            for(int i = GhostsPendingNetworkObjectId.Count - 1; i >= 0; i--)
+            {
+                var networkObject = GhostsPendingNetworkObjectId[i];
+                if (networkObject.IsGhostNetworkObjectIdValid())
+                {
+                    GhostsPendingNetworkObjectId.Remove(networkObject);
+                    if (NetworkManager.LogLevel == LogLevel.Developer)
+                    {
+                        Debug.Log($"[{nameof(RegisterGhostPendingSpawn)}] {networkObject.name}'s Ghost {nameof(NetworkObject.NetworkObjectId)} is valid. Re-registering.");
+                    }
+                    networkObject.RegisterGhostBridge();
+                }
+            }
+        }
+
+        internal void RegisterGhostPendingSpawn(NetworkObject networkObject, ulong networkObjectId)
         {
+            if (!networkObject.IsGhostNetworkObjectIdValid())
+            {
+                GhostsPendingNetworkObjectId.Add(networkObject);
+                if (NetworkManager.LogLevel == LogLevel.Developer)
+                {
+                    Debug.Log($"[{nameof(RegisterGhostPendingSpawn)}] {networkObject.name}'s Ghost {nameof(NetworkObject.NetworkObjectId)} ({networkObjectId}) seems invalid. Adding to the pending NetworkObjectId list.");
+                }
+                return;
+            }
             if (NetworkManager.LogLevel == LogLevel.Developer)
             {
                 Debug.Log($"[{nameof(RegisterGhostPendingSpawn)}] Registering {networkObject.name} with a {nameof(NetworkObject.NetworkObjectId)} of {networkObjectId}.");
             }
             if(GhostsPendingSpawn.TryAdd(networkObjectId, networkObject))
             {
                 // TODO-UNIFIED: We need a better way to preserve any hybrid instances pending NGO spawn.
-                // For now, move any pending object into the DDOL.                
+                // For now, move any pending object into the DDOL.
                 UnityEngine.Object.DontDestroyOnLoad(networkObject.gameObject);
             }
 
             NetworkManager.DeferredMessageManager.ProcessTriggers(IDeferredNetworkMessageManager.TriggerType.OnGhostSpawned, networkObjectId);
             if (GhostsArePendingSynchronization && GhostsPendingSynchronization.ContainsKey(networkObjectId))
             {
+                // TODO-UNIFIED: We need a better way to preserve any hybrid instances pending NGO spawn.
+                // NOTE: We might be able to use the NetworkSceneHandle to get the associated local scene handle to which we can use to get the targeted scene.
+                UnityEngine.SceneManagement.SceneManager.MoveGameObjectToScene(networkObject.gameObject, UnityEngine.SceneManagement.SceneManager.GetActiveScene());
+
                 // When the object is spawned, it will invoke GetGhostNetworkObjectForSpawn below which removes the entry from GhostsPendingSpawn
                 ProcessGhostPendingSynchronization(networkObjectId);
             }
@@ -64,6 +101,9 @@ internal NetworkObject GetGhostNetworkObjectForSpawn(ulong networkObjectId)
             }
             var networkObject = GhostsPendingSpawn[networkObjectId];
             GhostsPendingSpawn.Remove(networkObjectId);
+            // TODO-UNIFIED: We need a better way to preserve any hybrid instances pending NGO spawn.
+            // NOTE: We might be able to use the NetworkSceneHandle to get the associated local scene handle to which we can use to get the targeted scene.
+            UnityEngine.SceneManagement.SceneManager.MoveGameObjectToScene(networkObject.gameObject, UnityEngine.SceneManagement.SceneManager.GetActiveScene());
             return networkObject;
         }
 
@@ -100,10 +140,6 @@ internal void ProcessGhostPendingSynchronization(ulong networkObjectId, bool rem
             //{
             //    networkObject.InternalInSceneNetworkObjectsSpawned();
             //}
-
-            // TODO-UNIFIED: We need a better way to preserve any hybrid instances pending NGO spawn.
-            // NOTE: We might be able to use the NetworkSceneHandle to get the associated local scene handle to which we can use to get the targeted scene.
-            UnityEngine.SceneManagement.SceneManager.MoveGameObjectToScene(networkObject.gameObject, UnityEngine.SceneManagement.SceneManager.GetActiveScene());
             if (removeUponSpawn)
             {
                 GhostsArePendingSynchronization = GhostsPendingSynchronization.Count > 0;
@@ -2020,6 +2056,12 @@ internal NetworkSpawnManager(NetworkManager networkManager)
 
         internal void Shutdown()
         {
+#if UNIFIED_NETCODE
+            GhostsPendingNetworkObjectId.Clear();
+            GhostsPendingNetworkObjectId.Clear();
+            GhostsPendingSpawn.Clear();
+            GhostsPendingSynchronization.Clear();
+#endif
             NetworkObjectsToSynchronizeSceneChanges.Clear();
             CleanUpDisposedObjects.Clear();
         }