test-fix

Moving the motion authority check within the check to assure the SpawnSequenceController NetworkBehaviourReference is valid.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformOrderOfOperations.cs

@@ -1065,11 +1065,14 @@ public class ReferenceRpcHelper : NetworkBehaviour
             public void ReferenceTeleportRpc(NetworkBehaviourReference networkBehaviourReference, Vector3 position, Quaternion rotation, RpcParams rpcParams = default)
             {
                 networkBehaviourReference.TryGet<SpawnSequenceController>(out var spawnSequenceController);
-                // This validation assumes that user script will broadcast an update to everyone but only the motion authority will apply the update.
-                if (spawnSequenceController != null && spawnSequenceController.CanCommitToTransform)
+                if (spawnSequenceController != null)
                 {
-                    spawnSequenceController.Log($"[{nameof(ReferenceRpcHelper)}][{nameof(ReferenceTeleportRpc)}] Invoked on client-{NetworkManager.LocalClientId}.");
-                    spawnSequenceController.SetState(posIn: position, rotIn: rotation, teleportDisabled: false);
+                    // This validation assumes that user script will broadcast an update to everyone but only the motion authority will apply the update.
+                    if (spawnSequenceController.CanCommitToTransform)
+                    {
+                        spawnSequenceController.Log($"[{nameof(ReferenceRpcHelper)}][{nameof(ReferenceTeleportRpc)}] Invoked on client-{NetworkManager.LocalClientId}.");
+                        spawnSequenceController.SetState(posIn: position, rotIn: rotation, teleportDisabled: false);
+                    }
                 }
                 else
                 {