Optimization

Author: noellie-velez

com.unity.netcode.gameobjects/Runtime/Messaging/Messages/CreateObjectMessage.cs

@@ -29,68 +29,38 @@ internal struct CreateObjectMessage : INetworkMessage
         internal ulong NetworkObjectId;
 
 
-        //TODO Replace all bytes by boolean field
         private const byte k_IncludesSerializedObject = 0x01;
         private const byte k_UpdateObservers = 0x02;
         private const byte k_UpdateNewObservers = 0x04;
 
-
         private byte m_CreateObjectMessageTypeFlags;
 
-        internal bool IncludesSerializedObject
-        {
-            get
-            {
-                return GetFlag(k_IncludesSerializedObject);
-            }
-
-            set
-            {
-                SetFlag(value, k_IncludesSerializedObject);
-            }
-        }
-
-        internal bool UpdateObservers
-        {
-            get
-            {
-                return GetFlag(k_UpdateObservers);
-            }
+        internal bool IncludesSerializedObject;
+        internal bool UpdateObservers;
+        internal bool UpdateNewObservers;
 
-            set
-            {
-                SetFlag(value, k_UpdateObservers);
-            }
-        }
-
-        internal bool UpdateNewObservers
-        {
-            get
-            {
-                return GetFlag(k_UpdateNewObservers);
-            }
-
-            set
-            {
-                SetFlag(value, k_UpdateNewObservers);
-            }
-        }
-
-        private bool GetFlag(int flag)
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        internal uint GetBitsetRepresentation()
         {
-            return (m_CreateObjectMessageTypeFlags & flag) != 0;
+            uint bitset = 0;
+            if (IncludesSerializedObject) { bitset |= k_IncludesSerializedObject; }
+            if (UpdateObservers) { bitset |= k_UpdateObservers; }
+            if (UpdateNewObservers) { bitset |= k_UpdateNewObservers; }
+            return bitset;
         }
 
-        private void SetFlag(bool set, byte flag)
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        internal void SetStateFromBitset(uint bitset)
         {
-            if (set) { m_CreateObjectMessageTypeFlags = (byte)(m_CreateObjectMessageTypeFlags | flag); }
-            else { m_CreateObjectMessageTypeFlags = (byte)(m_CreateObjectMessageTypeFlags & ~flag); }
+            IncludesSerializedObject = (bitset & k_IncludesSerializedObject) != 0;
+            UpdateObservers = (bitset & k_UpdateObservers) != 0;
+            UpdateNewObservers = (bitset & k_UpdateNewObservers) != 0;
         }
 
         public void Serialize(FastBufferWriter writer, int targetVersion)
         {
-            // TODO Create a byte, see Landed PR, set all the values and then write
-            writer.WriteValueSafe(m_CreateObjectMessageTypeFlags);
+            uint getBitsetRepresentation = GetBitsetRepresentation();
+            writer.WriteValueSafe(getBitsetRepresentation);
 
             if (UpdateObservers)
             {
@@ -128,8 +98,9 @@ public bool Deserialize(FastBufferReader reader, ref NetworkContext context, int
                 return false;
             }
 
-            // TODO Read a byte, if bool returned
             reader.ReadValueSafe(out m_CreateObjectMessageTypeFlags);
+            SetStateFromBitset(m_CreateObjectMessageTypeFlags);
+
             if (UpdateObservers)
             {
                 var length = 0;