Skip to content

Commit 2409559

Browse files
update
Only assign the server or host world to NetCode.Netcode.Instance.m_ActiveWorld
1 parent 86b5ade commit 2409559

3 files changed

Lines changed: 12 additions & 10 deletions

File tree

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/UnifiedNetworkTransformTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ protected override bool OnSetVerboseDebug()
4747
protected override IEnumerator OnSetup()
4848
{
4949
// Creates the hybrid prefab
50-
m_Prefab = CreateHybridPrefab("HybridPrefab", true);
50+
m_Prefab = CreateNetworkObjectPrefab("HybridPrefab");
5151
m_Prefab.AddComponent<DoNothingNetworkTransform>();
5252
return base.OnSetup();
5353
}

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariable/NetworkListTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ namespace Unity.Netcode.RuntimeTests
1515
[TestFixture(HostOrServer.Host)]
1616
[TestFixture(HostOrServer.DAHost)]
1717
[TestFixture(HostOrServer.Server)]
18+
[TestFixture(HostOrServer.UnifiedHost)]
19+
[TestFixture(HostOrServer.UnifiedServer)]
1820
internal class NetworkListTests : NetcodeIntegrationTest
1921
{
2022
protected override int NumberOfClients => 3;

com.unity.netcode.gameobjects/Tests/Runtime/TestHelpers/NetcodeIntegrationTest.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2296,7 +2296,7 @@ protected GameObject CreateNetworkObjectPrefab(string baseName)
22962296
#if UNIFIED_NETCODE
22972297
if (m_AllPrefabsAsHybrid)
22982298
{
2299-
return CreateHybridPrefab(baseName);
2299+
return CreateHybridPrefab(baseName, true);
23002300
}
23012301
#endif
23022302
var prefabCreateAssertError = $"You can only invoke this method during {nameof(OnServerAndClientsCreated)} " +
@@ -2450,6 +2450,14 @@ internal void SpawnInstanceWithOwnership(NetworkObject networkObjectToSpawn, Net
24502450
}
24512451
else
24522452
{
2453+
#if UNIFIED_NETCODE
2454+
// TODO-FixMe: NetCode.Netcode.Instance is a singleton and might cause issues
2455+
// assigning this.
2456+
if (networkObjectToSpawn.HasGhost)
2457+
{
2458+
NetCode.Netcode.Instance.m_ActiveWorld = m_ServerNetworkManager.NetcodeWorld;
2459+
}
2460+
#endif
24532461
networkObjectToSpawn.NetworkManagerOwner = m_ServerNetworkManager; // Required to assure the server does the spawning
24542462
if (spawnAuthority == m_ServerNetworkManager)
24552463
{
@@ -2507,14 +2515,6 @@ protected void SpawnObjectInstance(NetworkObject networkObjectToSpawn, NetworkMa
25072515
private GameObject SpawnObject(NetworkObject prefabNetworkObject, NetworkManager owner, bool destroyWithScene = false, bool isPlayerObject = false)
25082516
{
25092517
Assert.IsTrue(prefabNetworkObject.GlobalObjectIdHash > 0, $"{nameof(GameObject)} {prefabNetworkObject.name} has a {nameof(NetworkObject.GlobalObjectIdHash)} value of 0! Make sure to make it a valid prefab before trying to spawn!");
2510-
#if UNIFIED_NETCODE
2511-
// TODO-FixMe: NetCode.Netcode.Instance is a singleton and might cause issues
2512-
// assigning this.
2513-
if (prefabNetworkObject.HasGhost)
2514-
{
2515-
NetCode.Netcode.Instance.m_ActiveWorld = owner.NetcodeWorld;
2516-
}
2517-
#endif
25182518
var newInstance = Object.Instantiate(prefabNetworkObject.gameObject);
25192519
var networkObjectToSpawn = newInstance.GetComponent<NetworkObject>();
25202520
SpawnObjectInstance(networkObjectToSpawn, owner, destroyWithScene, isPlayerObject);

0 commit comments

Comments
 (0)