Skip to content

Commit 227cf6c

Browse files
test - fix
For reals this time. Adding the defines for SCENE_MANAGEMENT_SCENE_HANDLE_NO_INT_CONVERSION and SCENE_MANAGEMENT_SCENE_HANDLE_MUST_USE_ULONG to the editor tests assembly.
1 parent aa3a121 commit 227cf6c

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

com.unity.netcode.gameobjects/Tests/Editor/Serialization/NetworkSceneHandleTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public void NetworkSceneHandleSerializationTest()
1313
using var writer = new FastBufferWriter(sizeof(ulong), Allocator.Temp);
1414
Assert.That(writer.Position, Is.EqualTo(0), "Writer position should be zero");
1515

16-
writer.WriteValue(handle);
16+
writer.WriteNetworkSerializable(handle);
1717
#if SCENE_MANAGEMENT_SCENE_HANDLE_MUST_USE_ULONG
1818
Assert.That(writer.Position, Is.EqualTo(sizeof(ulong)), $"Writer position should not be beyond size! Expected: {sizeof(ulong)} Actual: {writer.Position}");
1919
#else
@@ -22,7 +22,7 @@ public void NetworkSceneHandleSerializationTest()
2222

2323
var reader = new FastBufferReader(writer, Allocator.Temp);
2424
Assert.That(reader.Position, Is.EqualTo(0), "Reader position should be zero");
25-
reader.ReadValue(out NetworkSceneHandle deserializedHandle);
25+
reader.ReadNetworkSerializable(out NetworkSceneHandle deserializedHandle);
2626
#if SCENE_MANAGEMENT_SCENE_HANDLE_MUST_USE_ULONG
2727
Assert.That(reader.Position, Is.EqualTo(sizeof(ulong)), $"Reader position should not be beyond size! Expected: {sizeof(ulong)} Actual: {reader.Position}");
2828
#else
@@ -38,7 +38,7 @@ public void NetworkSceneHandleSerializationTest()
3838

3939
Assert.That(listWriter.Position, Is.EqualTo(0), "Writer position should be zero");
4040

41-
listWriter.WriteValue(handles);
41+
listWriter.WriteNetworkSerializable(handles);
4242
#if SCENE_MANAGEMENT_SCENE_HANDLE_MUST_USE_ULONG
4343
var expectedSize = sizeof(int) + (sizeof(ulong) * handles.Length);
4444
#else
@@ -48,7 +48,7 @@ public void NetworkSceneHandleSerializationTest()
4848

4949
var listReader = new FastBufferReader(listWriter, Allocator.Temp);
5050
Assert.That(listReader.Position, Is.EqualTo(0), "Reader position should be zero");
51-
listReader.ReadValue(out NetworkSceneHandle[] deserializedHandleList);
51+
listReader.ReadNetworkSerializable(out NetworkSceneHandle[] deserializedHandleList);
5252
Assert.That(listReader.Position, Is.EqualTo(expectedSize), $"Reader position should not be beyond expected size! Expected: {expectedSize} Actual: {listReader.Position}");
5353

5454
Assert.AreEqual(handles, deserializedHandleList);

com.unity.netcode.gameobjects/Tests/Editor/Unity.Netcode.Editor.Tests.asmdef

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,16 @@
4343
"name": "Unity",
4444
"expression": "6000.1.0a1",
4545
"define": "HOSTNAME_RESOLUTION_AVAILABLE"
46+
},
47+
{
48+
"name": "Unity",
49+
"expression": "6000.4.0a3",
50+
"define": "SCENE_MANAGEMENT_SCENE_HANDLE_NO_INT_CONVERSION"
51+
},
52+
{
53+
"name": "Unity",
54+
"expression": "6000.5.0a1",
55+
"define": "SCENE_MANAGEMENT_SCENE_HANDLE_MUST_USE_ULONG"
4656
}
4757
],
4858
"noEngineReferences": false

0 commit comments

Comments
 (0)