-
Notifications
You must be signed in to change notification settings - Fork 97
Add builder value validations #28
Copy link
Copy link
Open
Labels
base logicIssues that affect how the base logic of the projectIssues that affect how the base logic of the projectbuilderIssues related to the builder functionalityIssues related to the builder functionalityenhancementIssues related to a proposed enchancement to the projectIssues related to a proposed enchancement to the projectfeature requesthelp wanted
Description
Metadata
Metadata
Assignees
Labels
base logicIssues that affect how the base logic of the projectIssues that affect how the base logic of the projectbuilderIssues related to the builder functionalityIssues related to the builder functionalityenhancementIssues related to a proposed enchancement to the projectIssues related to a proposed enchancement to the projectfeature requesthelp wanted
Need to add logic to validate builder values. For the most part, this just means making sure that the
typeof the value of a variable passed to the builder matches the one expected.Currently, any builder value looks for the following token
```[var:::identifier_for_the_marker]```and expects the user to perform validation on their own.If we put the data type we expect in the
varfield, then it would be very easy to validate against it.For example, for the
C2_BLOCK_TIME, the current marker is```[var:::c2_block_time]```. Since thistype(C2_BLOCK_TIME)should always return<type 'int'>, it would be fairly simple to instead have the marker be```[int:::c2_block_time]```and refuse to compile if the provided value does not match the expected data type.This would be something nice to have, and be a fairly low level of effort; but isn't necessarily critical. It COULD be done for the beta release, but as of right now, will not be assigned as a blocker for release.