🤖 Merge PR DefinitelyTyped#71523 fix(yazl): make zipfile extend event emitter by @luxass

Author: luxass

types/yazl/index.d.ts

@@ -1,6 +1,7 @@
 /// <reference types="node" />
 
 import { Buffer } from "buffer";
+import { EventEmitter } from "events";
 
 export interface Options {
     mtime: Date;
@@ -27,7 +28,7 @@ export interface DosDateTime {
     time: number;
 }
 
-export class ZipFile {
+export class ZipFile extends EventEmitter {
     addFile(realPath: string, metadataPath: string, options?: Partial<Options>): void;
     outputStream: NodeJS.ReadableStream;
     addReadStream(input: NodeJS.ReadableStream, metadataPath: string, options?: Partial<ReadStreamOptions>): void;

types/yazl/package.json

@@ -19,6 +19,10 @@
         {
             "name": "Sean Marvi Oliver Genabe",
             "githubUsername": "seangenabe"
+        },
+        {
+            "name": "Lucas Nørgård",
+            "githubUsername": "luxass"
         }
     ]
 }

types/yazl/yazl-tests.ts

@@ -8,6 +8,12 @@ zipfile.addFile("path/to/file.txt", "path/in/zipfile.txt");
 // pipe() can be called any time after the constructor
 // $ExpectType ReadableStream
 zipfile.outputStream;
+
+// $ExpectType ZipFile
+zipfile.on("error", (err) => {
+    console.error("error", err);
+});
+
 zipfile.outputStream.pipe(fs.createWriteStream("output.zip")).on("close", () => {
     console.log("done");
 });