Skip to content

Commit 72efec9

Browse files
committed
Avoid set -e traps in selected-nodeid filter loops
1 parent 3d44246 commit 72efec9

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

.github/workflows/build-ultraplot.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,13 @@ jobs:
154154
status=0
155155
mapfile -t FILTERED_NODEIDS < <(
156156
while IFS= read -r nodeid; do
157-
[ -z "$nodeid" ] && continue
157+
if [ -z "$nodeid" ]; then
158+
continue
159+
fi
158160
path="${nodeid%%::*}"
159-
[ -f "$path" ] && printf '%s\n' "$nodeid"
161+
if [ -f "$path" ]; then
162+
printf '%s\n' "$nodeid"
163+
fi
160164
done < /tmp/pr_selected_nodeids.txt
161165
)
162166
echo "FILTERED_NODEIDS_BASE_COUNT=${#FILTERED_NODEIDS[@]}"
@@ -211,9 +215,13 @@ jobs:
211215
status=0
212216
mapfile -t FILTERED_NODEIDS < <(
213217
while IFS= read -r nodeid; do
214-
[ -z "$nodeid" ] && continue
218+
if [ -z "$nodeid" ]; then
219+
continue
220+
fi
215221
path="${nodeid%%::*}"
216-
[ -f "$path" ] && printf '%s\n' "$nodeid"
222+
if [ -f "$path" ]; then
223+
printf '%s\n' "$nodeid"
224+
fi
217225
done < /tmp/pr_selected_nodeids.txt
218226
)
219227
echo "FILTERED_NODEIDS_PR_COUNT=${#FILTERED_NODEIDS[@]}"

0 commit comments

Comments
 (0)