Fix GeoAxes._toggle_ticks to support bool and sequence label specs (#579)

Issue #578 reported that _toggle_ticks only handled string inputs and emitted a confusing warning for valid shorthand like labels='lb'. This diverged from the documented label input contract for lonlabels/latlabels/labels, which includes booleans and sequences.

The fix makes _toggle_ticks parse inputs through _to_label_array, so bool, string, and sequence forms are all accepted consistently with format() docs. Tick-side selection now uses axis-relevant sides only (bottom/top for x, left/right for y), which prevents false warnings for mixed shorthand specs and keeps behavior deterministic.

Added regression tests in test_geographic.py for labels='lb' (no warning, bottom+left tick placement) and direct _toggle_ticks calls with bool/sequence inputs. These tests fail on previous behavior and pass with this patch.

Author: cvanelteren

ultraplot/axes/geo.py

@@ -1100,43 +1100,42 @@ def _sharex_setup(
         super()._sharex_setup(sharex, labels=labels, limits=limits)
         return self.__share_axis_setup(sharex, which="x", labels=labels, limits=limits)
 
-    def _toggle_ticks(self, label: str | None, which: str) -> None:
+    def _toggle_ticks(self, label: Any, which: str) -> None:
         """
-        Ticks are controlled by matplotlib independent of the backend. We can toggle ticks on and of depending on the desired position.
+        Toggle x/y tick positions from geo label specifications.
+
+        Accepts the same `labels` forms as format(), including booleans, strings,
+        and boolean/string sequences. Only sides relevant to the requested axis
+        are considered: bottom/top for ``which='x'`` and left/right for
+        ``which='y'``.
         """
-        if not isinstance(label, str):
+        if label is None:
             return
 
-        # Only allow "lrbt" and "all" or "both"
-        label = label.replace("top", "t")
-        label = label.replace("bottom", "b")
-        label = label.replace("left", "l")
-        label = label.replace("right", "r")
-        match label:
-            case _ if len(label) == 2 and "t" in label and "b" in label:
-                self.xaxis.set_ticks_position("both")
-            case _ if len(label) == 2 and "l" in label and "r" in label:
-                self.yaxis.set_ticks_position("both")
-            case "t":
-                self.xaxis.set_ticks_position("top")
-            case "b":
-                self.xaxis.set_ticks_position("bottom")
-            case "l":
-                self.yaxis.set_ticks_position("left")
-            case "r":
-                self.yaxis.set_ticks_position("right")
-            case "all":
-                self.xaxis.set_ticks_position("both")
-                self.yaxis.set_ticks_position("both")
-            case "both":
-                if which == "x":
-                    self.xaxis.set_ticks_position("both")
-                else:
-                    self.yaxis.set_ticks_position("both")
-            case _:
-                warnings._warn_ultraplot(
-                    f"Not toggling {label=}. Input was not understood. Valid values are ['left', 'right', 'top', 'bottom', 'all', 'both']"
-                )
+        is_lon = which == "x"
+        try:
+            array = self._to_label_array(label, lon=is_lon)
+        except ValueError:
+            warnings._warn_ultraplot(
+                f"Not toggling label={label!r}. Input was not understood."
+            )
+            return
+
+        if is_lon:
+            side0, side1 = bool(array[2]), bool(array[3])  # bottom, top
+            axis = self.xaxis
+            name0, name1 = "bottom", "top"
+        else:
+            side0, side1 = bool(array[0]), bool(array[1])  # left, right
+            axis = self.yaxis
+            name0, name1 = "left", "right"
+
+        if side0 and side1:
+            axis.set_ticks_position("both")
+        elif side0:
+            axis.set_ticks_position(name0)
+        elif side1:
+            axis.set_ticks_position(name1)
 
     def _set_gridliner_adapter(
         self, which: str, adapter: Optional[_GridlinerAdapter]

ultraplot/tests/test_geographic.py

@@ -179,6 +179,38 @@ def test_geoticks_input_handling(recwarn):
     ax.format(lonticklen="1em")
 
 
+def test_geoticks_label_shorthand_lb_no_warning(recwarn):
+    fig, ax = uplt.subplots(proj="cyl")
+    ax.format(land=True, lonlines=30, latlines=30, labels="lb")
+    assert len(recwarn) == 0
+    assert ax[0].xaxis.get_ticks_position() == "bottom"
+    assert ax[0].yaxis.get_ticks_position() == "left"
+    uplt.close(fig)
+
+
+def test_toggle_ticks_supports_bool_and_sequence_specs():
+    fig, ax = uplt.subplots(proj="cyl")
+    geo = ax[0]
+    with warnings.catch_warnings(record=True) as caught:
+        warnings.simplefilter("always", uplt.warnings.UltraPlotWarning)
+        geo._toggle_ticks(True, "x")
+        assert geo.xaxis.get_ticks_position() == "bottom"
+        geo._toggle_ticks((True, True), "x")
+        assert geo.xaxis.get_ticks_position() in ("both", "default")
+        geo._toggle_ticks(("left", "bottom"), "x")
+        assert geo.xaxis.get_ticks_position() == "bottom"
+
+        geo._toggle_ticks(True, "y")
+        assert geo.yaxis.get_ticks_position() == "left"
+        geo._toggle_ticks((True, True), "y")
+        assert geo.yaxis.get_ticks_position() in ("both", "default")
+        geo._toggle_ticks(("left", "bottom"), "y")
+        assert geo.yaxis.get_ticks_position() == "left"
+
+    assert not caught
+    uplt.close(fig)
+
+
 @pytest.mark.parametrize(
     ("layout", "lonlabels", "latlabels"),
     [