Form submission via Enter key broken from v2.14.0‑rc.7 to v2.18.0 when multiple inputs exist

[adhamelgindy]

Bug Description

From version 2.14.0‑rc.7 up to 2.18.0, pressing the Enter key in a form does not trigger form submission if the form contains more than one input field. Submission works correctly only when there is a single input.

Affected Component

ui5-input in form

Expected Behaviour

Pressing Enter in any input should submit the form, regardless of the number of input fields.

Isolated Example

vue: https://playcode.io/vue-playground--019b7e90-e840-776f-91a2-bfe048137dc9
UI5 only: https://ui5.github.io/webcomponents/play/#eNrdU8GO0zAQ_RWvL9ut6hoOSCikCLGAxAkklgNSLq49bbw44yh2Wqqq_87YSVZZwa7EFSVSMm9m3ozfjM_cooFf6zo2jhdnjqoBXszBFdceI2AkuLwSgrVOnfad79GInXeGCfG2wvLqw5fbux9fP7KUlID0ZU7hflNxwIoTNj1lDcqQzegtQzw5SMayQB8XhYGdRTA37EyYsSGVKxh6hDcEXFJ-rpH9O99pMEJ75zuhzH0f4qNYVsqJ_78vVzYQFdO16gJEEv373SfxOus-utJsCT9YOLa-ixVn42QJPFoT642Bg9UgsrFiFm20yomglYPNy_WLkSzaSDW_qaZ1UMrBoqHKcar0u_XmxHJrRL1V-ue4L_kkBTuobiFEUO37B9dt8tyMBf6yZQJw3LQUQMI0zGPot41N3dM5gnewdn6_uB7Q64mst6-ExbaPVNb1qaHPySJvKR98_xgpUwNPtTq0SaPXnW0ji6c2UTXe9A5I89DpZCqL6_uQuYfALGESbpBQTvfoWTH4ZTVRzW7vhMyvrlzOWWprgC1lhbZJq8AqvpYzd-jbBOcGadf-zM0dPMp_RwrJI2y1JwSpZpC03lFmCQcifrn8BhcwieU

Steps to Reproduce

1. Open the reproduction link.
2. fill the input fields
3. Focus on any input field.
4. Press Enter.
5. Observe that the form does not submit.

Log Output, Stack Trace or Screenshots

Actual Behavior:

Form submission only works if there is exactly one input. With multiple inputs, pressing Enter has no effect.

1. Open the reproduction link.
2. removed an input field from the code
3. Fill the one and only field
4. Press Enter.
5. Submission works

Priority

None

UI5 Web Components Version

2.14.0‑rc.7 => 2.18.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

• I’m not disclosing any internal or sensitive information.

[ilhan007]

Hello @adhamelgindy

This is done by purpose to match the native input in form behavior, the submit event should be fired on enter key press and change event only if there is a single input in the form.

via this change
#12244

triggered by this issue
#12221

[github-actions]

This issue has been closed. To reopen, just leave a comment!

[fk-aconso]

But there is a difference if a form has a submit button, right?

@ilhan007 The behaviour described in #12221 is for the use-case without a submit button. If there is a submit button it should be triggered on pressing enter in a input, regardless of the number of inputs in the form as far as i know.

With the change you mentioned this does not work anymore.

Native example: https://jsfiddle.net/wph6j0ta/4/

UI5 Webcomponents: playground

[ilhan007]

Indeed, @fk-aconso you are right, there is a difference, we should have ensured that your use case continued to work before merging this.