Added missing unit tests

Author: jonathanmaron

src/Assert/AbstractAssert.php

@@ -56,9 +56,9 @@ protected static function valueToString($value): string
 
         if (is_object($value)) {
             if (method_exists($value, '__toString')) {
-                return get_class($value) . ': ' . self::valueToString($value->__toString());
+                $format = '%1$s: %2$s';
+                return sprintf($format, get_class($value), self::valueToString($value->__toString()));
             }
-
             return get_class($value);
         }
 
@@ -67,23 +67,10 @@ protected static function valueToString($value): string
         }
 
         if (is_string($value)) {
-            return sprintf('"%1$s"', $value);
+            $format = '"%1$s"';
+            return sprintf($format, $value);
         }
 
         return (string) $value;
     }
-
-    /**
-     * Convert value to class name or type
-     *
-     * @param mixed $value
-     *
-     * @return string
-     */
-    protected static function typeToString($value): string
-    {
-        $ret = is_object($value) ? get_class($value) : gettype($value);
-
-        return (string) $ret;
-    }
 }

test/Assert/AssertTest.php

@@ -15,6 +15,8 @@
 namespace TxTextControlTest\ReportingCloud\Assert;
 
 use PHPUnit\Framework\TestCase;
+use stdClass;
+use TxTextControlTest\ReportingCloud\Assert\TestAsset\ConcreteAssert as Assert;
 
 /**
  * Class AssertTest
@@ -47,4 +49,75 @@ class AssertTest extends TestCase
     use AssertStringTraitTest;
     use AssertIntegerTraitTest;
     use AssertBooleanTraitTest;
+
+    public function testValueToStringNull(): void
+    {
+        $expected = 'null';
+        $actual   = Assert::publicValueToString(null);
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function testValueToStringTrue(): void
+    {
+        $expected = 'true';
+        $actual   = Assert::publicValueToString(true);
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function testValueToStringFalse(): void
+    {
+        $expected = 'false';
+        $actual   = Assert::publicValueToString(false);
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function testValueToStringArray(): void
+    {
+        $expected = 'array';
+        $actual   = Assert::publicValueToString([1, 2, 3]);
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function testValueToStringObject(): void
+    {
+        $stdClass = new stdClass();
+
+        $expected = get_class($stdClass);
+        $actual   = Assert::publicValueToString($stdClass);
+
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function testValueToStringObjectWithToString(): void
+    {
+        $stdClass = new class extends stdClass
+        {
+            public function __toString()
+            {
+                return 'abc';
+            }
+        };
+
+        $expected = sprintf('%1$s: %2$s', get_class($stdClass), Assert::publicValueToString($stdClass->__toString()));
+        $actual   = Assert::publicValueToString($stdClass);
+
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function testValueToStringResource(): void
+    {
+        $handle = fopen(__FILE__, 'r');
+
+        $expected = 'resource';
+        $actual   = Assert::publicValueToString($handle);
+
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function testValueToStringString(): void
+    {
+        $expected = '"abc"';
+        $actual   = Assert::publicValueToString('abc');
+        $this->assertEquals($expected, $actual);
+    }
 }

test/Assert/TestAsset/ConcreteAssert.php

@@ -0,0 +1,38 @@
+<?php
+declare(strict_types=1);
+
+/**
+ * ReportingCloud PHP SDK
+ *
+ * PHP SDK for ReportingCloud Web API. Authored and supported by Text Control GmbH.
+ *
+ * @link      https://www.reporting.cloud to learn more about ReportingCloud
+ * @link      https://github.com/TextControl/txtextcontrol-reportingcloud-php for the canonical source repository
+ * @license   https://raw.githubusercontent.com/TextControl/txtextcontrol-reportingcloud-php/master/LICENSE.md
+ * @copyright © 2019 Text Control GmbH
+ */
+
+namespace TxTextControlTest\ReportingCloud\Assert\TestAsset;
+
+use TxTextControl\ReportingCloud\Assert\AbstractAssert;
+
+/**
+ * Class ConcreteAssert (for testing only)
+ *
+ * @package TxTextControlTest\ReportingCloud
+ * @author  Jonathan Maron (@JonathanMaron)
+ */
+class ConcreteAssert extends AbstractAssert
+{
+    /**
+     * Convert value to string (public version for testing)
+     *
+     * @param mixed $value
+     *
+     * @return string
+     */
+    public static function publicValueToString($value): string
+    {
+        return self::valueToString($value);
+    }
+}