Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Commit d6d048a

Browse files
committed
Repair Quarkus Vert.x benchmark
Ongres SCRAM was missing (required for authentication). Signed-off-by: Thomas Segismont <tsegismo@ibm.com>
1 parent e52b3e4 commit d6d048a

4 files changed

Lines changed: 9 additions & 4 deletions

File tree

frameworks/Java/quarkus/benchmark_config.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@
7070
"database_os": "Linux",
7171
"display_name": "Quarkus, Vert.x",
7272
"notes": "",
73-
"versus": "Vert.x",
74-
"tags": ["broken"]
73+
"versus": "Vert.x"
7574
},
7675
"reactive-routes-pgclient": {
7776
"json_url": "/json",

frameworks/Java/quarkus/vertx/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@
2424
<groupId>io.vertx</groupId>
2525
<artifactId>vertx-pg-client</artifactId>
2626
</dependency>
27+
<dependency>
28+
<groupId>com.ongres.scram</groupId>
29+
<artifactId>client</artifactId>
30+
<version>2.1</version>
31+
</dependency>
2732
<dependency>
2833
<groupId>io.quarkus</groupId>
2934
<artifactId>quarkus-vertx</artifactId>

frameworks/Java/quarkus/vertx/src/main/java/io/quarkus/benchmark/repository/PgClientFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.quarkus.benchmark.repository;
22

3+
import io.quarkus.logging.Log;
34
import io.vertx.core.Vertx;
45
import io.vertx.pgclient.PgConnectOptions;
56
import jakarta.annotation.PreDestroy;
@@ -36,7 +37,7 @@ PgConnectionPool connectionPool() {
3637
try {
3738
pgConnectionPool = new PgConnectionPool(vertx, pgConnectOptions());
3839
} catch (final Exception e) {
39-
// TODO LOG ME: usually means inability to connect to the database
40+
Log.error("Failed to create pgConnectionPool", e);
4041
} finally {
4142
this.pgConnectionPool = pgConnectionPool;
4243
return pgConnectionPool;

frameworks/Java/quarkus/vertx/src/main/java/io/quarkus/benchmark/repository/PgConnectionPool.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public PgConnectionPool(final Vertx vertx, final PgConnectOptions options) {
6868
final AsyncResult<PgClientConnection> ar = completedConnections.get(i);
6969
if (ar == null || ar.failed()) {
7070
forceCloseEstablishedConnections(completedConnections);
71-
throw new IllegalStateException("cannot establish all connections");
71+
throw new IllegalStateException("cannot establish all connections", ar != null ? ar.cause() : null);
7272
} else {
7373
pgConnections.set(i, ar.result());
7474
}

0 commit comments

Comments
 (0)