From 6bc421c9240af4983672701b30462f8d4df9847b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pascal=20K=C3=BCsgen?= Date: Tue, 27 Jan 2026 12:39:26 +0100 Subject: [PATCH] fix(core): getIsSomePageRowsSelected - do not return false when all page rows selected MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Pascal Küsgen --- .changeset/late-radios-decide.md | 5 +++++ packages/table-core/src/features/RowSelection.ts | 5 +---- 2 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 .changeset/late-radios-decide.md diff --git a/.changeset/late-radios-decide.md b/.changeset/late-radios-decide.md new file mode 100644 index 0000000000..a88679495b --- /dev/null +++ b/.changeset/late-radios-decide.md @@ -0,0 +1,5 @@ +--- +'@tanstack/table-core': patch +--- + +getIsSomePageRowsSelected no longer returns false when all rows of a page are selected diff --git a/packages/table-core/src/features/RowSelection.ts b/packages/table-core/src/features/RowSelection.ts index e5fddaba9d..749834ccfc 100644 --- a/packages/table-core/src/features/RowSelection.ts +++ b/packages/table-core/src/features/RowSelection.ts @@ -445,10 +445,7 @@ export const RowSelection: TableFeature = { } table.getIsSomePageRowsSelected = () => { - const paginationFlatRows = table.getPaginationRowModel().flatRows - return table.getIsAllPageRowsSelected() - ? false - : paginationFlatRows + return table.getPaginationRowModel().flatRows .filter((row) => row.getCanSelect()) .some((d) => d.getIsSelected() || d.getIsSomeSelected()) }