Skip to content

Commit a0e45a1

Browse files
committed
【fix】UT called its 'done' callback more than once
1 parent 63730fd commit a0e45a1

File tree

2 files changed

+12
-18
lines changed

2 files changed

+12
-18
lines changed

test/mapboxgl/overlay/DeckglLayerSpec.js

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ describe('mapboxgl_DeckglLayer', () => {
6868
setTimeout(() => {
6969
expect(deckglLayer.deckGL).not.toBeNull();
7070
done();
71-
}, 4000)
71+
}, 1000)
7272
});
7373

7474
it('onAdd_ArcLayer', (done) => {
@@ -88,9 +88,8 @@ describe('mapboxgl_DeckglLayer', () => {
8888

8989
setTimeout(() => {
9090
expect(deckglLayer.deckGL).not.toBeNull();
91-
9291
done();
93-
}, 4000)
92+
}, 1000)
9493
});
9594

9695
it('onAdd_HexagonLayer', (done) => {
@@ -111,7 +110,7 @@ describe('mapboxgl_DeckglLayer', () => {
111110
setTimeout(() => {
112111
expect(deckglLayer.deckGL).not.toBeNull();
113112
done();
114-
}, 4000)
113+
}, 1000)
115114
});
116115

117116
it('onAdd_PolygonLayer', (done) => {
@@ -132,7 +131,7 @@ describe('mapboxgl_DeckglLayer', () => {
132131
setTimeout(() => {
133132
expect(deckglLayer.deckGL).not.toBeNull();
134133
done();
135-
}, 4000)
134+
}, 1000)
136135
});
137136

138137
it('onAdd_scatter-plot', (done) => {
@@ -171,7 +170,7 @@ describe('mapboxgl_DeckglLayer', () => {
171170
setTimeout(() => {
172171
expect(deckglLayer.deckGL).not.toBeNull();
173172
done();
174-
}, 4000)
173+
}, 1000)
175174
});
176175

177176
it('setVisibility', (done) => {
@@ -203,14 +202,13 @@ describe('mapboxgl_DeckglLayer', () => {
203202
expect(deckglLayer.deckGL).not.toBeNull();
204203
expect(deckglLayer.data).toEqual(data);
205204
expect(deckglLayer.data.length).toEqual(2);
206-
done();
207-
}, 3000)
205+
}, 1000)
208206
setTimeout(() => {
209207
deckglLayer.removeFromMap()
210208
expect(deckglLayer.deckGL).not.toBeNull();
211209
expect(deckglLayer.data.length).toEqual(0);
212210
done();
213-
}, 3000)
211+
}, 1000)
214212

215213

216214
});
@@ -239,14 +237,13 @@ describe('mapboxgl_DeckglLayer', () => {
239237
deckglLayer.addData(data);
240238
expect(deckglLayer.deckGL).not.toBeNull();
241239
expect(deckglLayer.data.length).toEqual(4);
242-
done();
243-
}, 3000)
240+
}, 1000)
244241
setTimeout(() => {
245242
deckglLayer.removeData();
246243
expect(deckglLayer.deckGL).not.toBeNull();
247244
expect(deckglLayer.data.length).toEqual(0);
248245
done();
249-
}, 3000)
246+
}, 1000)
250247
});
251248

252249
it('setStyle,hexagon-layer', (done) => {
@@ -264,7 +261,7 @@ describe('mapboxgl_DeckglLayer', () => {
264261
deckglLayer.setStyle({ radius: 1000 });
265262
expect(deckglLayer.deckGL.props.radius).toEqual(1000);
266263
done();
267-
}, 3000)
264+
}, 1000)
268265

269266
});
270267
});

test/openlayers/services/FieldServiceSpec.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ describe('openlayers_FieldService', () => {
189189
service.getFieldStatisticsInfo(fieldStatisticsParameters, (result) => {
190190
serviceResult = result;
191191
});
192-
let count = 0;
192+
193193
setTimeout(() => {
194194
try {
195195
expect(service).not.toBeNull();
@@ -206,10 +206,7 @@ describe('openlayers_FieldService', () => {
206206
expect(serviceResult.error).not.toBeNull();
207207
expect(serviceResult.error.code).toEqual(404);
208208
expect(serviceResult.error.errorMsg).toBe("数据源World1不存在,获取相应的数据服务组件失败");
209-
count++;
210-
if (count === 6) {
211-
done();
212-
}
209+
done();
213210
} catch (e) {
214211
console.log("'fail:getFieldStatisticsInfo'案例失败" + exception.name + ":" + exception.message);
215212
expect(false).toBeTruthy();

0 commit comments

Comments
 (0)