Unable to change the highlighting color via `highlight_color`

[davidhcefx]

Description

• According to your instruction, I should be able to change the highlighting color through the "highlight_color" config.
• However, setting it to any value failed to work. Including:
  • #fff
  • region.greenish
  • region.yellowish
• I discovered that every time I invoked Toggle Trailing Spaces Highlight, the config will be overwritten to "highlight_color": "region.redish"
• It seems that line 371 is doing something nasty.
  • Why do it need to change the user's settings? If it alter the user's settings, can it change it back? What if Sublime were exited before the changes being reverted?

TrailingSpaces/trailing_spaces.py

Lines 360 to 374 in ff34629

	class ToggleTrailingSpacesCommand(sublime_plugin.WindowCommand):
	def run(self) -> None:
	view = self.window.active_view()
	if not view:
	return
	if max_size_exceeded(view):
	sublime.status_message("File is too big, trailing spaces handling disabled.")
	return
	state = toggle_highlighting(view)
	settings.highlight_color = current_highlight_color
	settings.save()
	sublime.status_message('Highlighting of trailing spaces is %s' % state)

• Other issues with the same cause:
  • Toggling Trailing Spaces Highlighting resets color to null #160
  • Settings Being Overwritten? #65