From 23f3a2866d2fe66498bc0eb5b7be8f6bfd83aebd Mon Sep 17 00:00:00 2001
From: Stuart Meeks <stuart.meeks@stuartmeeks.net>
Date: Mon, 1 Jun 2026 09:02:31 +0000
Subject: [PATCH] Fix tag chips unreadable in Light theme
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Tag chips on snip cards (and the parameter-type badge in Shared
parameters) set an accent background but no foreground, so the text
fell back to the theme default — dark in Light theme, leaving dark text
on the accent fill. Set the on-accent text brush so it stays light and
readable in both themes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 CHANGELOG.md                            | 3 +++
 src/Snipdeck.App/Controls/SnipCard.xaml | 6 +++++-
 src/Snipdeck.App/Views/ShellPage.xaml   | 3 ++-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ae44e8c..dd21e5f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   edits survive app updates. Delete it to restore the default set.
 
 ### Fixed
+- **Tag chips unreadable in Light theme.** Tag chips on snip cards (and the
+  parameter-type badge in Shared parameters) showed dark text on the accent fill in
+  Light theme. They now use the on-accent text colour, readable in both themes.
 - **Window caption buttons invisible in Light theme.** The minimise, maximise and
   close glyphs were always white, leaving them barely visible against the light
   title bar. They now take a theme-appropriate colour, update when you switch
diff --git a/src/Snipdeck.App/Controls/SnipCard.xaml b/src/Snipdeck.App/Controls/SnipCard.xaml
index 47e9015..1ee6ddd 100644
--- a/src/Snipdeck.App/Controls/SnipCard.xaml
+++ b/src/Snipdeck.App/Controls/SnipCard.xaml
@@ -80,8 +80,12 @@
                     <Border Background="{ThemeResource AccentFillColorSecondaryBrush}"
                             CornerRadius="10"
                             Padding="8,2">
+                        <!-- Explicit on-accent foreground: without it the text falls
+                             back to the theme's default (dark in Light theme), which
+                             is unreadable on the accent fill. -->
                         <TextBlock Text="{x:Bind}"
-                                   Style="{ThemeResource CaptionTextBlockStyle}" />
+                                   Style="{ThemeResource CaptionTextBlockStyle}"
+                                   Foreground="{ThemeResource TextOnAccentFillColorPrimaryBrush}" />
                     </Border>
                 </DataTemplate>
             </ItemsControl.ItemTemplate>
diff --git a/src/Snipdeck.App/Views/ShellPage.xaml b/src/Snipdeck.App/Views/ShellPage.xaml
index 14e5a81..d5e9268 100644
--- a/src/Snipdeck.App/Views/ShellPage.xaml
+++ b/src/Snipdeck.App/Views/ShellPage.xaml
@@ -513,7 +513,8 @@
                                                         Padding="8,2"
                                                         VerticalAlignment="Center">
                                                     <TextBlock Text="{x:Bind TypeDisplay}"
-                                                               Style="{ThemeResource CaptionTextBlockStyle}" />
+                                                               Style="{ThemeResource CaptionTextBlockStyle}"
+                                                               Foreground="{ThemeResource TextOnAccentFillColorPrimaryBrush}" />
                                                 </Border>
                                             </Grid>
                                             <TextBlock Style="{ThemeResource CaptionTextBlockStyle}"