Enhance test suite reliability and error handling

- Improve test runner error tracking and reporting
- Add more robust error handling in test utility functions
- Enhance test scripts with better directory navigation and error checking
- Fix shellcheck warnings and improve shell script practices
- Add explicit exit codes and comprehensive test logging

Author: vgrichina

test/test_runner.sh

@@ -24,6 +24,12 @@ for test_file in "$TEST_DIR"/unit/test_*.sh; do
         echo "Running tests in $(basename "$test_file")"
         echo "------------------------------------"
         bash "$test_file"
+        
+        # Capture exit status
+        test_status=$?
+        if [ $test_status -ne 0 ]; then
+            echo "Test file $(basename "$test_file") failed with status $test_status"
+        fi
     fi
 done
 

test/test_utils.sh

@@ -6,10 +6,6 @@
 TESTS_PASSED=0
 TESTS_FAILED=0
 
-# Get the directory where the test_utils.sh script is located
-TEST_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-PROJECT_ROOT="$(cd "$TEST_DIR/.." && pwd)"
-
 # Function to run a test
 # Usage: run_test "test_name" "command_to_run"
 run_test() {
@@ -19,7 +15,7 @@ run_test() {
     echo -n "- Testing $test_name... "
 
     # Run the command and capture output and exit status
-    output=$(eval $command 2>&1)
+    output=$(eval "$command" 2>&1)
     status=$?
 
     if [ $status -eq 0 ]; then
@@ -45,7 +41,9 @@ create_test_dir() {
 # Usage: cleanup_test_dir "$test_dir"
 cleanup_test_dir() {
     local test_dir=$1
-    rm -rf "$test_dir"
+    if [ -d "$test_dir" ]; then
+        rm -rf "$test_dir"
+    fi
 }
 
 # Function to assert that a string contains another string
@@ -80,5 +78,9 @@ create_test_file() {
     local file_path=$1
     local size_bytes=$2
 
-    dd if=/dev/zero of="$file_path" bs=1 count=$size_bytes status=none
+    dd if=/dev/zero of="$file_path" bs=1 count="$size_bytes" status=none 2>/dev/null
 }
+
+# Export variables to be available in subprocesses
+export TESTS_PASSED
+export TESTS_FAILED

test/unit/test_argument_parsing.sh

@@ -3,38 +3,50 @@
 # test_argument_parsing.sh - Tests for command-line argument parsing
 
 # Get the directory where this test script is located
-TEST_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+TEST_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 PROJECT_ROOT="$(cd "$TEST_DIR/.." && pwd)"
 
 # Source test utilities
 source "$TEST_DIR/test_utils.sh"
 
+# Test description
+echo "Testing command-line argument parsing"
+
 # Create a temporary directory for this test
 test_dir=$(create_test_dir)
+echo "Using temporary directory: $test_dir"
 
 # Setup test file
 echo "// Test file" > "$test_dir/test.js"
 
+# Ensure context script is executable
+chmod +x "$PROJECT_ROOT/context"
+
 # Test 1: Help option
 echo "Testing help option"
-run_test "help_option" "$PROJECT_ROOT/context --help | grep -q 'Usage:'"
+run_test "help_option" "\"$PROJECT_ROOT/context\" --help | grep -q 'Usage:'"
 
 # Test 2: Summary option
 echo "Testing summary option"
-run_test "summary_option" "cd $test_dir && $PROJECT_ROOT/context --files=test.js --summary | grep -q 'Summary:'"
+run_test "summary_option" "cd \"$test_dir\" && \"$PROJECT_ROOT/context\" --files=\"test.js\" --summary | grep -q 'Summary:'"
 
 # Test 3: No ls-files option
 echo "Testing no ls-files option"
-run_test "no_ls_files_option" "cd $test_dir && $PROJECT_ROOT/context --files=test.js --no-ls-files | grep -qv 'Repository Files'"
+run_test "no_ls_files_option" "cd \"$test_dir\" && \"$PROJECT_ROOT/context\" --files=\"test.js\" --no-ls-files | grep -qv 'Repository Files'"
 
 # Test 4: Verbose option
 echo "Testing verbose option with non-existent file"
-output=$(cd $test_dir && $PROJECT_ROOT/context --files=nonexistent.js --verbose 2>&1 || true)
-run_test "verbose_option" "echo '$output' | grep -q 'Warning: File not found:'"
+output=$(cd "$test_dir" && "$PROJECT_ROOT/context" --files="nonexistent.js" --verbose 2>&1 || true)
+run_test "verbose_option" "echo \"$output\" | grep -q 'Warning: File not found:'"
 
 # Test 5: Invalid option
 echo "Testing invalid option"
-run_test "invalid_option" "! $PROJECT_ROOT/context --invalid-option 2>/dev/null"
+run_test "invalid_option" "! \"$PROJECT_ROOT/context\" --invalid-option 2>/dev/null"
 
 # Clean up
+echo "Cleaning up temporary directory"
 cleanup_test_dir "$test_dir"
+
+# Exit with success
+exit 0

test/unit/test_file_processing.sh

@@ -3,14 +3,19 @@
 # test_file_processing.sh - Tests for file processing functionality
 
 # Get the directory where this test script is located
-TEST_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+TEST_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 PROJECT_ROOT="$(cd "$TEST_DIR/.." && pwd)"
 
 # Source test utilities
 source "$TEST_DIR/test_utils.sh"
 
+# Test description
+echo "Testing file processing functionality"
+
 # Create a temporary directory for this test
 test_dir=$(create_test_dir)
+echo "Using temporary directory: $test_dir"
 
 # Setup test files
 mkdir -p "$test_dir/src"
@@ -19,21 +24,29 @@ echo "// Test file 2" > "$test_dir/src/file2.js"
 mkdir -p "$test_dir/node_modules"
 echo "// Should be excluded" > "$test_dir/node_modules/exclude_me.js"
 
+# Ensure context script is executable
+chmod +x "$PROJECT_ROOT/context"
+
 # Test 1: Basic file inclusion
 echo "Testing basic file inclusion"
-run_test "basic_file_inclusion" "cd $test_dir && $PROJECT_ROOT/context --files=src/file1.js | grep -q 'Test file 1'"
+run_test "basic_file_inclusion" "cd \"$test_dir\" && \"$PROJECT_ROOT/context\" \"src/file1.js\" | grep -q 'Test file 1'"
 
 # Test 2: File pattern inclusion
 echo "Testing file pattern inclusion"
-run_test "file_pattern_inclusion" "cd $test_dir && $PROJECT_ROOT/context --files='src/*.js' | grep -q 'Test file 2'"
+run_test "file_pattern_inclusion" "cd \"$test_dir\" && \"$PROJECT_ROOT/context\" --files=\"src/*.js\" | grep -q 'Test file 2'"
 
 # Test 3: Exclude pattern
 echo "Testing exclude pattern"
-run_test "exclude_pattern" "cd $test_dir && $PROJECT_ROOT/context --files='**/*.js' --exclude='node_modules/**' | grep -qv 'Should be excluded'"
+run_test "exclude_pattern" "cd \"$test_dir\" && \"$PROJECT_ROOT/context\" --files=\"**/*.js\" --exclude=\"node_modules/**\" | grep -qv 'Should be excluded'"
 
 # Test 4: Multiple file patterns
 echo "Testing multiple file patterns"
-run_test "multiple_file_patterns" "cd $test_dir && $PROJECT_ROOT/context --files='src/file1.js' --files='src/file2.js' | grep -q 'Test file 1' && cd $test_dir && $PROJECT_ROOT/context --files='src/file1.js' --files='src/file2.js' | grep -q 'Test file 2'"
+multiple_files_test="cd \"$test_dir\" && \"$PROJECT_ROOT/context\" --files=\"src/file1.js\" --files=\"src/file2.js\" | grep -q 'Test file 1' && cd \"$test_dir\" && \"$PROJECT_ROOT/context\" --files=\"src/file1.js\" --files=\"src/file2.js\" | grep -q 'Test file 2'"
+run_test "multiple_file_patterns" "$multiple_files_test"
 
 # Clean up
+echo "Cleaning up temporary directory"
 cleanup_test_dir "$test_dir"
+
+# Exit with success
+exit 0

test/unit/test_size_calculations.sh

@@ -3,36 +3,49 @@
 # test_size_calculations.sh - Tests for size calculation and truncation
 
 # Get the directory where this test script is located
-TEST_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+TEST_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 PROJECT_ROOT="$(cd "$TEST_DIR/.." && pwd)"
 
 # Source test utilities
 source "$TEST_DIR/test_utils.sh"
 
+# Test description
+echo "Testing size calculations and truncation"
+
 # Create a temporary directory for this test
 test_dir=$(create_test_dir)
+echo "Using temporary directory: $test_dir"
 
 # Setup test files
 create_test_file "$test_dir/small.txt" 1024  # 1KB file
 create_test_file "$test_dir/large.txt" 5120  # 5KB file
 
+# Ensure context script is executable
+chmod +x "$PROJECT_ROOT/context"
+
 # Test 1: Max size limit not exceeded
 echo "Testing max size limit not exceeded"
-run_test "max_size_not_exceeded" "cd $test_dir && $PROJECT_ROOT/context --files=small.txt --max-size=2KB"
+run_test "max_size_not_exceeded" "cd \"$test_dir\" && \"$PROJECT_ROOT/context\" --files=\"small.txt\" --max-size=2KB"
 
 # Test 2: Max size limit exceeded
 echo "Testing max size limit exceeded"
-run_test "max_size_exceeded" "cd $test_dir && ! $PROJECT_ROOT/context --files=small.txt --files=large.txt --max-size=2KB"
+max_size_exceeded_test="cd \"$test_dir\" && ! \"$PROJECT_ROOT/context\" --files=\"small.txt\" --files=\"large.txt\" --max-size=2KB"
+run_test "max_size_exceeded" "$max_size_exceeded_test"
 
 # Test 3: File truncation
 echo "Testing file truncation"
-result=$(cd $test_dir && $PROJECT_ROOT/context --files=large.txt --truncate-large=2KB)
-run_test "file_truncation" "echo '$result' | grep -q '\[File truncated due to size limit\]'"
+result=$(cd "$test_dir" && "$PROJECT_ROOT/context" --files="large.txt" --truncate-large=2KB)
+run_test "file_truncation" "echo \"$result\" | grep -q '\[File truncated due to size limit\]'"
 
 # Test 4: Human readable size display
 echo "Testing human readable size display"
-result=$(cd $test_dir && $PROJECT_ROOT/context --files=small.txt --show-file-sizes)
-run_test "human_readable_size" "echo '$result' | grep -q 'Size: 1 KB'"
+result=$(cd "$test_dir" && "$PROJECT_ROOT/context" --files="small.txt" --show-file-sizes)
+run_test "human_readable_size" "echo \"$result\" | grep -q 'Size: 1 KB'"
 
 # Clean up
+echo "Cleaning up temporary directory"
 cleanup_test_dir "$test_dir"
+
+# Exit with success
+exit 0