Skip to content

ConfigServerClientOptions-related Enhancements #1664

@TimHess

Description

@TimHess

IHostApplicationBuilder.AddConfigServer should have an overload that takes a ConfigServerClientOptions instance.

Furthermore, the following code in Steeltoe:

if (!string.IsNullOrEmpty(hostEnvironment.EnvironmentName) &&
    hostEnvironment.EnvironmentName != "Production")
{
    // Only take IHostEnvironment.EnvironmentName when it was explicitly set (it defaults to "Production").
    // In the default case, we want the various other ways of setting the environment name to kick in.
    options.Environment = hostEnvironment.EnvironmentName;
}

is problematic. ConfigServerClientOptions.EnvironmentName should default to an empty string, and then ConfigServerConfigurationProvider should assume Production if still empty.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ReleaseLine/4.xIdentified as a feature/fix for the 4.x release lineType/enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions