Skip to content

Commit 4e0102a

Browse files
authored
chore(styles): ensure editor plays well with tne new stacks v3 styles (#505)
1 parent 0625eb9 commit 4e0102a

15 files changed

Lines changed: 65 additions & 87 deletions

File tree

.changeset/config.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,8 @@
1010
"access": "public",
1111
"baseBranch": "beta",
1212
"updateInternalDependencies": "patch",
13-
"ignore": []
13+
"ignore": [],
14+
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
15+
"onlyUpdatePeerDependentsWhenOutOfRange": true
16+
}
1417
}

.changeset/odd-rules-jump.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@stackoverflow/stacks-editor": minor
3+
---
4+
5+
ensure editor continue to work with stacks v3 styles

package-lock.json

Lines changed: 6 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"@playwright/test": "^1.42.1",
7373
"@stackoverflow/commitlint-config": "^1.0.0",
7474
"@stackoverflow/prettier-config": "^1.0.0",
75-
"@stackoverflow/stacks": "^2.3.2",
75+
"@stackoverflow/stacks": "^3.0.0-beta.19",
7676
"@stackoverflow/tsconfig": "^1.0.0",
7777
"@types/jest": "^29.5.12",
7878
"@types/markdown-it": "^14.0.0",

plugins/official/stack-snippets/src/snippet-view.ts

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,14 @@ export class StackSnippetView implements NodeView {
8989
ctas.className = "snippet-ctas d-flex ai-center";
9090
if (opts && opts.renderer) {
9191
const snippetButtonContainer = document.createElement("div");
92-
snippetButtonContainer.className = "snippet-buttons mb0 gs4";
92+
snippetButtonContainer.className = "snippet-buttons d-flex mb0 g4";
9393
ctas.appendChild(snippetButtonContainer);
9494
this.buildRunButton(snippetButtonContainer);
9595
this.buildEditButton(snippetButtonContainer);
9696

9797
const snippetResultButtonContainer = document.createElement("div");
9898
snippetResultButtonContainer.className =
99-
"snippet-result-buttons d-flex mb0 ml-auto gs4";
99+
"snippet-result-buttons d-flex mb0 ml-auto g24";
100100
ctas.appendChild(snippetResultButtonContainer);
101101
this.showButton = this.buildShowButton(
102102
snippetResultButtonContainer
@@ -290,12 +290,12 @@ export class StackSnippetView implements NodeView {
290290
private buildRunButton(container: HTMLDivElement): void {
291291
const runCodeButton = document.createElement("button");
292292
runCodeButton.type = "button";
293-
runCodeButton.className = "s-btn s-btn__filled flex--item";
293+
runCodeButton.className = "s-btn s-btn__icon flex--item";
294294
runCodeButton.title = "Run code snippet";
295295
runCodeButton.setAttribute("aria-label", "Run code snippet");
296296
// create the svg svg-icon-bg element
297297
const runIcon = document.createElement("span");
298-
runIcon.className = "svg-icon-bg mr4 iconPlay";
298+
runIcon.className = "svg-icon-bg mr4 h16 iconPlay";
299299
runCodeButton.append(runIcon);
300300
const runText = document.createElement("span");
301301
runText.textContent = "Run code snippet";
@@ -353,7 +353,7 @@ export class StackSnippetView implements NodeView {
353353
private buildEditButton(container: HTMLDivElement): HTMLButtonElement {
354354
const editButton = document.createElement("button");
355355
editButton.type = "button";
356-
editButton.className = "s-btn s-btn__outlined flex--item";
356+
editButton.className = "s-btn s-btn__clear flex--item";
357357
editButton.title = "Edit code snippet";
358358
editButton.setAttribute("aria-label", "Edit code snippet");
359359
editButton.textContent = "Edit code snippet";
@@ -368,11 +368,11 @@ export class StackSnippetView implements NodeView {
368368
private buildHideButton(container: HTMLDivElement): HTMLButtonElement {
369369
const hideButton = document.createElement("button");
370370
hideButton.type = "button";
371-
hideButton.className = "s-btn flex--item";
371+
hideButton.className = "s-btn s-btn__link d-flex flex--item";
372372
hideButton.title = "Hide results";
373373
hideButton.setAttribute("aria-label", "Hide results");
374374
const hideIcon = document.createElement("span");
375-
hideIcon.className = "svg-icon-bg mr4 iconEyeOff";
375+
hideIcon.className = "svg-icon-bg iconEyeOff";
376376
hideButton.append(hideIcon);
377377
const hideText = document.createElement("span");
378378
hideText.textContent = "Hide results";
@@ -394,11 +394,11 @@ export class StackSnippetView implements NodeView {
394394
private buildShowButton(container: HTMLDivElement): HTMLButtonElement {
395395
const showButton = document.createElement("button");
396396
showButton.type = "button";
397-
showButton.className = "s-btn flex--item d-none";
397+
showButton.className = "s-btn s-btn__link flex--item d-flex d-none";
398398
showButton.title = "Show results";
399399
showButton.setAttribute("aria-label", "Show results");
400400
const hideIcon = document.createElement("span");
401-
hideIcon.className = "svg-icon-bg mr4 iconEye";
401+
hideIcon.className = "svg-icon-bg iconEye";
402402
showButton.append(hideIcon);
403403
const showText = document.createElement("span");
404404
showText.textContent = "Show results";
@@ -423,7 +423,7 @@ export class StackSnippetView implements NodeView {
423423
): HTMLButtonElement {
424424
const expandButton = document.createElement("button");
425425
expandButton.type = "button";
426-
expandButton.className = "s-btn flex--item";
426+
expandButton.className = "s-btn s-btn__link d-flex flex--item";
427427
expandButton.title = "Expand Snippet";
428428
expandButton.setAttribute("aria-label", "Expand Snippet");
429429
expandButton.addEventListener("click", () => {
@@ -436,7 +436,7 @@ export class StackSnippetView implements NodeView {
436436
);
437437
});
438438
const expandIcon = document.createElement("span");
439-
expandIcon.className = "svg-icon-bg mr4 iconShareSm";
439+
expandIcon.className = "svg-icon-bg iconShareSm";
440440
expandButton.append(expandIcon);
441441
const expandText = document.createElement("span");
442442
expandText.textContent = "Expand Snippet";
@@ -451,7 +451,8 @@ export class StackSnippetView implements NodeView {
451451
): HTMLButtonElement {
452452
const collapseButton = document.createElement("button");
453453
collapseButton.type = "button";
454-
collapseButton.className = "s-btn flex--item td-underline ml-auto";
454+
collapseButton.className =
455+
"s-btn s-btn__link d-flex flex--item ml-auto";
455456
collapseButton.title = "Return to post";
456457
collapseButton.setAttribute("aria-label", "Return to post");
457458
collapseButton.addEventListener("click", () => {
@@ -464,7 +465,7 @@ export class StackSnippetView implements NodeView {
464465
);
465466
});
466467
const collapseIcon = document.createElement("span");
467-
collapseIcon.className = "svg-icon-bg mr4 iconShareSm";
468+
collapseIcon.className = "svg-icon-bg iconShareSm";
468469
collapseButton.append(collapseIcon);
469470
const expandText = document.createElement("span");
470471
expandText.textContent = "Return to post";

0 commit comments

Comments
 (0)