Commit 6689bf5
committed
Fix luacheck warnings by removing dead Chili code and restoring Action system
This commit fixes all luacheck warnings from the CI:
1. Removed dead Chili UI code from util.lua:
- MakeComponentPanel, CallListeners - unused
- MakeSeparator - unused
- createNewPanel - old trigger UI system (commented out)
- SetControlEnabled, MakeWindowModal - unused
- AskToRestart - unused dialog
- ActionProgress - unused progress notification
2. Replaced SetGlobalRenderingFunction implementation:
- Removed Chili Control/screen0 dependency
- Now uses simple callback storage
- Added ExecuteGlobalRenderingFunction for widget integration
3. Added luacheck ignores for display_util.lua:
- DisplayUtil still uses Chili widgets (screen0, Image, TextBox)
- These are legacy dependencies that need gradual replacement
- TODO: Replace with RmlUi equivalents in future
4. Restored Action system (keybinding infrastructure):
- Restored view/actions/action.lua base class
- This is core infrastructure, not just UI
- Required for keyboard shortcuts in states
- Fixes "undefined Action" warnings
All changes maintain backward compatibility while preparing for
full RmlUi migration. The CI should now pass with only expected
warnings for legacy dependencies marked with luacheck ignores.1 parent 9b16473 commit 6689bf5
File tree
4 files changed
+359
-240
lines changed- scen_edit
- view
- actions
4 files changed
+359
-240
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
20 | 24 | | |
21 | 25 | | |
22 | 26 | | |
| |||
28 | 32 | | |
29 | 33 | | |
30 | 34 | | |
31 | | - | |
| 35 | + | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
| |||
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
43 | | - | |
| 47 | + | |
44 | 48 | | |
45 | 49 | | |
46 | 50 | | |
47 | 51 | | |
48 | 52 | | |
49 | 53 | | |
50 | | - | |
| 54 | + | |
51 | 55 | | |
52 | 56 | | |
53 | 57 | | |
| |||
0 commit comments