Method naming improvement (HasEnumLookupAttribute)

pergerch · pergerch · commit 1ad473cd20a5 · 2018-12-12T14:22:34.000+01:00
diff --git a/src/SpatialFocus.EntityFrameworkCore.Extensions/EnumLookupExtension.cs b/src/SpatialFocus.EntityFrameworkCore.Extensions/EnumLookupExtension.cs
@@ -29,7 +29,7 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku
 					continue;
 				}
 
-				if (enumOptions.UseEnumsWithAttributesOnly && !propertyType.HasEnumWithAttribute())
+				if (enumOptions.UseEnumsWithAttributesOnly && !propertyType.HasEnumLookupAttribute())
 				{
 					continue;
 				}
@@ -106,7 +106,7 @@ private static Type GetEnumOrNullableEnumType(this Type propertyType)
 			return propertyType.IsEnum ? propertyType : propertyType.GetGenericArguments()[0];
 		}
 
-		private static bool HasEnumWithAttribute(this Type propertyType)
+		private static bool HasEnumLookupAttribute(this Type propertyType)
 		{
 			if (propertyType.GetCustomAttributes(typeof(EnumLookupAttribute), true).Any())
 			{

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public static void ConfigureEnumLookup(this ModelBuilder modelBuilder, EnumLooku`
`29`	`29`	`continue;`
`30`	`30`	`}`
`31`	`31`
`32`		`- if (enumOptions.UseEnumsWithAttributesOnly && !propertyType.HasEnumWithAttribute())`
	`32`	`+ if (enumOptions.UseEnumsWithAttributesOnly && !propertyType.HasEnumLookupAttribute())`
`33`	`33`	`{`
`34`	`34`	`continue;`
`35`	`35`	`}`
`@@ -106,7 +106,7 @@ private static Type GetEnumOrNullableEnumType(this Type propertyType)`
`106`	`106`	`return propertyType.IsEnum ? propertyType : propertyType.GetGenericArguments()[0];`
`107`	`107`	`}`
`108`	`108`
`109`		`- private static bool HasEnumWithAttribute(this Type propertyType)`
	`109`	`+ private static bool HasEnumLookupAttribute(this Type propertyType)`
`110`	`110`	`{`
`111`	`111`	`if (propertyType.GetCustomAttributes(typeof(EnumLookupAttribute), true).Any())`
`112`	`112`	`{`