SONARJAVA-6184 S4605: FP when having SpringBootApplication followed by ComponentScan annotation

Author: asya-vorobeva

java-checks-test-sources/default/src/main/java/checks/spring/s4605/mixed/app1/App1.java

@@ -0,0 +1,14 @@
+package checks.spring.s4605.mixed.app1;
+
+import org.springframework.boot.SpringApplication;
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+import org.springframework.context.annotation.ComponentScan;
+import org.springframework.context.annotation.FilterType;
+
+@SpringBootApplication
+@ComponentScan(excludeFilters = {@ComponentScan.Filter(type = FilterType.REGEX, pattern = "checks.spring.s4605.mixed.app1.smth")})
+public class App1 {
+  static void main(String[] args) {
+    SpringApplication.run(checks.spring.s4605.springBootApplication.app.SpringBootApp1.class, args);
+  }
+}

java-checks-test-sources/default/src/main/java/checks/spring/s4605/mixed/app1/visible/VisibleService.java

@@ -0,0 +1,10 @@
+package checks.spring.s4605.mixed.app1.visible;
+
+import org.springframework.stereotype.Component;
+
+interface VisibleServiceI {
+}
+
+@Component
+public class VisibleService implements VisibleServiceI { // Compliant
+}

java-checks-test-sources/default/src/main/java/checks/spring/s4605/springBootApplication/app/SpringBootApp1.java

@@ -2,12 +2,9 @@
 
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
-import org.springframework.context.annotation.ComponentScan;
-import org.springframework.context.annotation.FilterType;
 import org.springframework.stereotype.Component;
 
 @SpringBootApplication
-@ComponentScan(excludeFilters = {@ComponentScan.Filter(type = FilterType.REGEX, pattern = "checks.spring.s4605.springBootApplication.app.smth")})
 public class SpringBootApp1 {
 
   public static void main(String[] args) {

java-checks-test-sources/default/src/main/java/checks/spring/s4605/springBootApplication/app/notOk/NotOkImpl.java

@@ -115,7 +115,6 @@ void testSpringBootApplication() {
     List<String> files = Arrays.asList(
       mainCodeSourcesPath(testFolder + "Ko/Ko.java"),
       mainCodeSourcesPath(testFolder + "app/Ok/Ok.java"),
-      mainCodeSourcesPath(testFolder + "app/notOk/NotOkImpl.java"),
       mainCodeSourcesPath(testFolder + "app/SpringBootApp1.java"),
       mainCodeSourcesPath(testFolder + "secondApp/AnotherOk.java"),
       mainCodeSourcesPath(testFolder + "secondApp/SpringBootApp2.java"));
@@ -158,6 +157,19 @@ void testSpringBootApplicationWithAnnotation() {
       .verifyIssues();
   }
 
+  @Test
+  void testBothAnnotationsTogether() {
+    final String folderApp = BASE_PATH + "mixed/app1/";
+    List<String> testFiles = Arrays.asList(
+      mainCodeSourcesPath(folderApp + "App1.java"),
+      mainCodeSourcesPath(folderApp + "visible/VisibleService.java"));
+
+    CheckVerifier.newVerifier()
+      .onFiles(testFiles)
+      .withCheck(new SpringBeansShouldBeAccessibleCheck())
+      .verifyNoIssues();
+  }
+
   @Test
   void caching() throws NoSuchAlgorithmException, IOException {
     var unchangedFiles = Stream.of(