sonar-java/java-checks-test-sources/default/src/test/java/checks/tests/AssertThrowsInsteadOfTryCatchFailCheckSample.java at 1affe0f7dae352903c8cac0a3e44f94edec05043 · SonarSource/sonar-java · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
package checks.tests;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.*;

public class AssertThrowsInsteadOfTryCatchFailCheckSample {
  @Test
  void tests() {
    try {
      raise();
      fail(); // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^
    } catch (Exception _) {
      // test passed
    }
    try {
      dontRaise();
    } catch (Exception _) {
      fail(); // Noncompliant {{Use assertDoesNotThrow() instead of try/catch and fail() in the catch block.}}
//    ^^^^^^
    }

    try {
      raise();
      org.junit.Assert.fail("expected exception"); // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } catch (Exception _) {
      // test passed
    }

    try {
      raise();
      junit.framework.Assert.fail("expected exception"); // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } catch (Exception _) {
      // test passed
    }

    try {
      raise();
      org.fest.assertions.Fail.fail("expected exception"); // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } catch (Exception _) {
      // test passed
    }

    try {
      raise();
      org.assertj.core.api.Fail.fail("expected exception"); // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } catch (Exception _) {
      // test passed
    }

    try {
      raise();
      org.assertj.core.api.Assertions.fail("expected exception"); // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } catch (Exception _) {
      // test passed
    }

    try {
      raise();
      org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown(IllegalStateException.class); // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } catch (Exception _) {
      // test passed
    }

    try {
      raise();
      org.assertj.core.api.AssertionsForClassTypes.fail("expected exception"); // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } catch (Exception _) {
      // test passed
    }

    try {
      raise();
      org.assertj.core.api.AssertionsForInterfaceTypes.fail("expected exception"); // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } catch (Exception _) {
      // test passed
    }


    try {
      raise();
      fail(() -> "expected exception");  // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } catch (Exception _) {
      // test passed
    }

    try {
      raise();
      fail(() -> "expected exception");  // Noncompliant {{Use assertThrows() instead of try/catch and fail() in the try block.}}
//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    } finally {}

    assertThrows(IllegalStateException.class, AssertThrowsInsteadOfTryCatchFailCheckSample::raise); // compliant
    assertDoesNotThrow(AssertThrowsInsteadOfTryCatchFailCheckSample::dontRaise); // compliant
    nonAnnotatedFunctionFN();
  }

  private void nonAnnotatedFunctionFN() {
    org.assertj.core.api.AssertionsForInterfaceTypes.fail("expected exception"); // FN
  }

  @org.junit.Test
  public void junit4AnnotationDontRaise() {
    try {
      fail("expected exception"); // TN - junit5 fail in junit4 test
    } catch (Exception _) {
      // test passed
    }
    try {
      org.junit.Assert.fail("expected exception"); // TN - junit4 fail in junit4 test
    } catch (Exception _) {
      // test passed
    }
  }

  private static void raise() {
    throw new IllegalStateException();
  }

  private static void dontRaise() {
    // do nothing
  }
}