Integration test complete!

Author: SolidKalium

DEVELOPMENT.md

@@ -60,7 +60,7 @@ To enable GitHub Pages: go to `Settings -> Pages` in the repository, then select
 ## Local MediaWiki testing
 
 For end-to-end testing in a real wiki environment, this repo includes a minimal `docker-compose.yml` for MediaWiki plus MariaDB.
-The MediaWiki container is built from `test/docker/mediawiki.Dockerfile`, which adds Lua 5.1 for Scribunto's `lua-standalone` engine.
+The MediaWiki container is built from `test/docker/mediawiki.Dockerfile`, which adds Lua 5.1 for Scribunto's `luastandalone` engine.
 
 Start it with:
 
@@ -84,16 +84,22 @@ http://localhost:8080
 Recommended workflow:
 1. Run `python3 scripts/build_artifacts.py` so the current export file exists in `dist/`.
 2. Start the stack with `docker compose up -d`.
+   * After first startup or after enabling/changing extension config in `LocalSettings.php`, run:
+
+   ```bash
+   docker compose exec mediawiki php maintenance/run.php update
+   ```
+
 3. Login with credentials admin / adminpassword. *The config does not expose the container to the internet and you shouldn't use these credentials if you do.*
 4. Import the generated export into the running wiki using one of these methods:
-   * In `Special:Import`, upload the local `dist/mediawiki-export.xml` file from your machine. Use any import prefix (e.g. "imported")
+   * In `Special:Import`, upload the local `dist/mediawiki-export.xml` file from your machine. Use any import prefix (e.g. "imported") for the edit logs.
    * Or import from inside the container with:
 
    ```bash
    docker compose exec mediawiki php maintenance/run.php importDump /imports/mediawiki-export.xml
    ```
 
-   * Note that these will clobber any existing pages, though undo will be available in the version history.
+   * Note that these will clobber any existing pages, though undo will be available in the version history. The import will not work correctly until Scribunto's install maintenance has run.
 
 5. Update `MediaWiki:Gadgets-definition` to load `MediaWiki:Gadget-inline-datetime.js` and `MediaWiki:Gadget-inline-datetime.css`.
 6. Optionally add `Template:IDT` manually if you want the short alias.
@@ -104,5 +110,5 @@ Notes:
 * `test/docker/LocalSettings.php` is committed as a local test-only configuration for this Docker setup. It should not be reused for production or public deployment.
 * The generated `dist/` directory is mounted read-only into the MediaWiki container at `/imports`.
 * `test/docker/LocalSettings.php` is mounted read-only into the MediaWiki container as `/var/www/html/LocalSettings.php`.
-* The MediaWiki image includes `lua5.1` so `wfLoadExtension( 'Scribunto' )` can use the `lua-standalone` engine from the committed test config.
+* The `mediawiki:1.43` image doesn't include Scribunto's bundled standalone Lua binary, so we install system lua5.1 and we have `test/docker/LocalSettings.php` explicitly point Scribunto at `/usr/bin/lua5.1`.
 * Uploaded wiki files live in a named Docker volume, so restarting the stack does not wipe images.

README.md

@@ -88,11 +88,10 @@ This repository's export file includes:
 After importing the pages, add an entry to `MediaWiki:Gadgets-definition`. A typical entry looks like:
 
 ```mediawiki
-* inline-datetime[ResourceLoader|default|type=general]|Gadget-inline-datetime-config.js|Gadget-inline-datetime.js|Gadget-inline-datetime.css
+* inline-datetime[ResourceLoader|default|type=general]|inline-datetime-config.js|inline-datetime.js|inline-datetime.css
 ```
 
 Option notes:
-* `ResourceLoader` — registers the gadget as a ResourceLoader module for better performance and dependency support; remove this option if your wiki does not use ResourceLoader
 * `default` — enables the gadget for all users automatically; replace with `hidden` if you want it available but opt-in only
 * `type=general` — runs scripts in the page scope; required for this gadget to access the page DOM
 * The config file **must be listed before** the main JS file so it is executed first

TODO.md

@@ -4,10 +4,7 @@
 
 * Improve lua fallback to be closer to the JS?
   * Include style classes?
-* verify usage documentation is aligned (specs, wiki doc page, visual test page)
-* Test the export file
-  * How will MediaWiki handle "duplicate" pages?
-  * Document easy docker setup for this
+    * This could interfere with the current no-JS demo
 * audit code for readability and obviousness
 
 ## Later

gadget/Template_IDT.wikitext

@@ -1 +1,3 @@
-{{InlineDateTime|start={{{start|{{{1|}}}}}}|end={{{end|{{{2|}}}}}}|server={{{server|}}}|raw={{{raw|}}}}}
+<includeonly>{{InlineDateTime|start={{{start|{{{1|}}}}}}|end={{{end|{{{2|}}}}}}|server={{{server|}}}|raw={{{raw|}}}}}</includeonly><noinclude>
+Short alias for [[Template:InlineDateTime]].
+</noinclude>

gadget/Template_InlineDateTime.wikitext

@@ -1,4 +1,4 @@
-{{#invoke:InlineDateTime|main}}<noinclude>
-{{documentation}}
+<includeonly>{{#invoke:InlineDateTime|main}}</includeonly><noinclude>
+{{/doc}}
 [[Category:InlineDateTime templates]]
 </noinclude>

gadget/Template_InlineDateTime_doc.wikitext

@@ -1,6 +1,6 @@
 == Usage ==
 
-<code><nowiki>{{InlineDateTime}}</nowiki></code> (or the short alias <code><nowiki>{{IDT}}</nowiki></code>) displays an inline datetime or date range with automatic timezone conversion for the reader. Times are shown with a tooltip providing conversions to the reader's local time and/or server times.
+<code><nowiki>{{InlineDateTime}}</nowiki></code> (or the short alias <code><nowiki>{{InlineDateTime}}</nowiki></code>) displays an inline datetime or date range with automatic timezone conversion for the reader. Times are shown with a tooltip providing conversions to the reader's local time and/or server times.
 
 === Parameters ===
 
@@ -38,6 +38,7 @@
 
 '''Server time range (most common):'''
 <pre>{{InlineDateTime|start=2026-03-12 12:00|end=2026-03-29 12:00}}</pre>
+What it looks like: {{InlineDateTime|start=2026-03-12 12:00|end=2026-03-29 12:00}}
 
 '''Absolute time (maintenance window):'''
 <pre>{{InlineDateTime|start=2026-03-12 06:00 +8|end=2026-03-12 12:00 +8}}</pre>

test/docker/LocalSettings.php

@@ -168,9 +168,10 @@
 wfLoadExtension( 'SyntaxHighlight_GeSHi' );
 wfLoadExtension( 'Scribunto' );
 $wgScribuntoDefaultEngine = 'luastandalone';
-$wgScribuntoEngineConf['luastandalone']['luaPath'] = '/usr/bin/lua5.1'; // TODO is this needed? If not, we can remove the build step that added it.
+// The MediaWiki Docker image used for local testing does not ship Scribunto's
+// standalone Lua binary, so this test setup uses system lua5.1 instead.
+$wgScribuntoEngineConf['luastandalone']['luaPath'] = '/usr/bin/lua5.1';
 $wgScribuntoEngineConf['luastandalone']['errorFile'] = '/tmp/scribunto.log';
-// $wgScribuntoEngineConf['lua-standalone']['luaPath'] = "$IP/extensions/Scribunto/includes/engines/LuaStandalone/binaries/lua5.1_linux_64_generic/lua";
 wfLoadExtension( 'CategoryTree' );
 wfLoadExtension( 'ReplaceText' );
 

test/docker/mediawiki.Dockerfile

@@ -1,6 +1,6 @@
 FROM mediawiki:1.43
 
-# Install Lua 5.1 for Scribunto's lua-standalone engine.
+# Install Lua 5.1 for Scribunto's luastandalone engine.
 RUN apt-get update \
     && apt-get install -y --no-install-recommends lua5.1 \
     && rm -rf /var/lib/apt/lists/*