From ff865fa02d7569c8d2d400f922c79855de551c68 Mon Sep 17 00:00:00 2001
From: jdalton <john.david.dalton@gmail.com>
Date: Mon, 13 Apr 2026 12:07:51 -0400
Subject: [PATCH] fix: resolve quality scan issues

- Fix inverted skip-build condition in publish.mjs (validated artifacts
  only when skipping build, not when running it)
- Fix duplicate file diff reporting in release-npm-packages.mjs (missing
  file reported as both "missing" and "differs")
- Change bcaKeysMap from Map to WeakMap in make-npm-override.mjs to
  allow garbage collection of browser compat data objects
---
 scripts/npm/make-npm-override.mjs    | 2 +-
 scripts/npm/release-npm-packages.mjs | 3 +--
 scripts/publish.mjs                  | 4 ++--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/scripts/npm/make-npm-override.mjs b/scripts/npm/make-npm-override.mjs
index 9ff4a0fe..ec4c4707 100644
--- a/scripts/npm/make-npm-override.mjs
+++ b/scripts/npm/make-npm-override.mjs
@@ -96,7 +96,7 @@ const { positionals: cliPositionals, values: cliArgs } = parseArgs({
   strict: false,
 })
 
-const bcaKeysMap = new Map()
+const bcaKeysMap = new WeakMap()
 
 const esShimChoices = [
   {
diff --git a/scripts/npm/release-npm-packages.mjs b/scripts/npm/release-npm-packages.mjs
index 3ba05188..2ba59aa6 100644
--- a/scripts/npm/release-npm-packages.mjs
+++ b/scripts/npm/release-npm-packages.mjs
@@ -267,8 +267,7 @@ async function hasPackageChanged(pkg, manifest_, options) {
         const message = `${pkg.name}: File '${file}' exists in published package but not locally`
         state?.warnings.push(message)
         changed = true
-      }
-      if (remoteHash !== localHash) {
+      } else if (remoteHash !== localHash) {
         const message = `${pkg.name}: File '${file}' content differs`
         state?.changes.push(message)
         changed = true
diff --git a/scripts/publish.mjs b/scripts/publish.mjs
index 486e6706..af203f69 100644
--- a/scripts/publish.mjs
+++ b/scripts/publish.mjs
@@ -183,8 +183,8 @@ async function main() {
     logger.log('  Publish Runner')
     logger.log('────────────────────────────────────────────────────────────')
 
-    // Validate build artifacts if not skipping
-    if (values['skip-build']) {
+    // Validate build artifacts if not skipping.
+    if (!values['skip-build']) {
       const artifactsExist = await validateBuildArtifacts()
       if (!artifactsExist && !values.force) {
         logger.error('Build artifacts missing - run pnpm build first')