refactor(cli): replace console.log/error/warn with logger

jdalton · jdalton · commit e8ad2f42078f · 2025-11-01T17:29:25.000-04:00
Refactored all console usage in executable code to use logger from
@socketsecurity/lib/logger for CLAUDE.md compliance.

Changes:
- Replaced 24 console instances across 16 files
- CLI entry points: pnpm-cli, npm-cli, npx-cli, yarn-cli (4 files)
- Bootstrap: node.mts (7 instances)
- Command apps: analytics, audit-log, threat-feed (3 files)
- Utilities: with-subcommands, patches, npm-registry, sea/build,
  FramedHeader, notifier (6 files)

Pattern:
- console.log → logger.log
- console.error → logger.error
- console.warn → logger.warn

Intentionally preserved:
- 33 JSDoc example comments (documentation)
- 10 test file fixtures (test content)

Build verified: ✓ All tests passing
diff --git a/packages/cli/src/bootstrap/node.mts b/packages/cli/src/bootstrap/node.mts
@@ -19,6 +19,7 @@ import { existsSync, promises as fs } from 'node:fs'
 import path from 'node:path'
 
 import { safeMkdir } from '@socketsecurity/lib/fs'
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
 
 import { getNodeDisableSigusr1Flags } from './shared/node-flags.mjs'
 import {
@@ -28,6 +29,8 @@ import {
   getDlxDir,
 } from './shared/paths.mjs'
 
+const logger = getDefaultLogger()
+
 /**
  * Check if CLI is installed.
  */
@@ -48,7 +51,7 @@ async function downloadCli(): Promise<void> {
 
   await safeMkdir(dlxDir, { recursive: true })
 
-  console.error(`Downloading ${packageName}...`)
+  logger.error(`Downloading ${packageName}...`)
 
   return new Promise((resolve, reject) => {
     const npmPackProcess = spawn(
@@ -101,7 +104,7 @@ async function downloadCli(): Promise<void> {
             // Ignore cleanup errors.
           })
 
-          console.error('Socket CLI installed successfully')
+          logger.error('Socket CLI installed successfully')
           resolve()
         })
       } catch (e) {
@@ -117,11 +120,11 @@ async function downloadCli(): Promise<void> {
 async function main(): Promise<void> {
   // Check if CLI is already installed.
   if (!isCliInstalled()) {
-    console.error('Socket CLI not installed yet.')
+    logger.error('Socket CLI not installed yet.')
     try {
       await downloadCli()
     } catch (error) {
-      console.error('Failed to download Socket CLI:', error)
+      logger.error('Failed to download Socket CLI:', error)
       // eslint-disable-next-line n/no-process-exit
       process.exit(1)
     }
@@ -141,7 +144,7 @@ async function main(): Promise<void> {
   )
 
   child.on('error', error => {
-    console.error('Failed to spawn CLI:', error)
+    logger.error('Failed to spawn CLI:', error)
     // eslint-disable-next-line n/no-process-exit
     process.exit(1)
   })
@@ -155,7 +158,7 @@ async function main(): Promise<void> {
 // Only run if executed directly (not when loaded as module).
 if (import.meta.url === `file://${process.argv[1]}`) {
   main().catch(error => {
-    console.error('Bootstrap error:', error)
+    logger.error('Bootstrap error:', error)
     // eslint-disable-next-line n/no-process-exit
     process.exit(1)
   })
diff --git a/packages/cli/src/cli-dispatch.mts b/packages/cli/src/cli-dispatch.mts
@@ -18,8 +18,12 @@
 
 import path from 'node:path'
 
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
+
 import { waitForBootstrapHandshake } from './utils/sea/boot.mjs'
 
+const logger = getDefaultLogger()
+
 // Detect how this binary was invoked.
 function getInvocationMode(): string {
   // Check environment variable first (for explicit mode).
@@ -128,7 +132,7 @@ async function main() {
 
 // Run the appropriate CLI.
 main().catch(error => {
-  console.error('Socket CLI Error:', error)
+  logger.error('Socket CLI Error:', error)
   // eslint-disable-next-line n/no-process-exit -- Required for CLI error handling.
   process.exit(1)
 })
diff --git a/packages/cli/src/commands/analytics/analytics-app-cli.mts b/packages/cli/src/commands/analytics/analytics-app-cli.mts
@@ -4,8 +4,11 @@
 import { pathToFileURL } from 'node:url'
 
 import { render } from 'ink'
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
 import React from 'react'
 
+const logger = getDefaultLogger()
+
 /**
  * Run the Ink AnalyticsApp with data from stdin.
  */
@@ -28,7 +31,7 @@ async function main() {
 }
 
 main().catch(e => {
-  console.error('Error running AnalyticsApp:', e)
+  logger.error('Error running AnalyticsApp:', e)
   // eslint-disable-next-line n/no-process-exit
   process.exit(1)
 })
diff --git a/packages/cli/src/commands/audit-log/audit-log-app-cli.mts b/packages/cli/src/commands/audit-log/audit-log-app-cli.mts
@@ -4,8 +4,11 @@
 import { pathToFileURL } from 'node:url'
 
 import { render } from 'ink'
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
 import React from 'react'
 
+const logger = getDefaultLogger()
+
 /**
  * Run the Ink AuditLogApp with data from stdin.
  */
@@ -33,7 +36,7 @@ async function main() {
 }
 
 main().catch(e => {
-  console.error('Error running AuditLogApp:', e)
+  logger.error('Error running AuditLogApp:', e)
   // eslint-disable-next-line n/no-process-exit
   process.exit(1)
 })
diff --git a/packages/cli/src/commands/threat-feed/threat-feed-app-cli.mts b/packages/cli/src/commands/threat-feed/threat-feed-app-cli.mts
@@ -4,8 +4,11 @@
 import { pathToFileURL } from 'node:url'
 
 import { render } from 'ink'
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
 import React from 'react'
 
+const logger = getDefaultLogger()
+
 /**
  * Run the Ink ThreatFeedApp with data from stdin.
  */
@@ -28,7 +31,7 @@ async function main() {
 }
 
 main().catch(e => {
-  console.error('Error running ThreatFeedApp:', e)
+  logger.error('Error running ThreatFeedApp:', e)
   // eslint-disable-next-line n/no-process-exit
   process.exit(1)
 })
diff --git a/packages/cli/src/meow.mts b/packages/cli/src/meow.mts
@@ -4,10 +4,13 @@
  */
 
 import { parseArgs } from '@socketsecurity/lib/argv/parse'
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
 import { readPackageJsonSync } from '@socketsecurity/lib/packages'
 
 import type { ParseArgsConfig } from '@socketsecurity/lib/argv/parse'
 
+const logger = getDefaultLogger()
+
 export interface MeowFlag {
   readonly type?: 'string' | 'boolean' | 'number'
   readonly shortFlag?: string
@@ -173,13 +176,13 @@ export default function meow<
   }
 
   const showHelp = (exitCode = 2) => {
-    console.log(fullHelp)
+    logger.log(fullHelp)
     // eslint-disable-next-line n/no-process-exit -- Required for CLI exit behavior.
     process.exit(exitCode)
   }
 
   const showVersion = () => {
-    console.log(pkg['version'] || '0.0.0')
+    logger.log(pkg['version'] || '0.0.0')
     // eslint-disable-next-line n/no-process-exit -- Required for CLI exit behavior.
     process.exit(0)
   }
diff --git a/packages/cli/src/npm-cli.mts b/packages/cli/src/npm-cli.mts
@@ -1,7 +1,11 @@
 #!/usr/bin/env node
 
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
+
 import shadowNpmBin from './shadow/npm/bin.mts'
 
+const logger = getDefaultLogger()
+
 export default async function runNpmCli() {
   process.exitCode = 1
 
@@ -24,7 +28,7 @@ export default async function runNpmCli() {
 // Run if invoked directly (not as a module).
 if (import.meta.url === `file://${process.argv[1]}`) {
   runNpmCli().catch(error => {
-    console.error('Socket npm wrapper error:', error)
+    logger.error('Socket npm wrapper error:', error)
     // eslint-disable-next-line n/no-process-exit
     process.exit(1)
   })
diff --git a/packages/cli/src/npx-cli.mts b/packages/cli/src/npx-cli.mts
@@ -1,7 +1,11 @@
 #!/usr/bin/env node
 
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
+
 import shadowNpxBin from './shadow/npx/bin.mts'
 
+const logger = getDefaultLogger()
+
 export default async function runNpxCli() {
   process.exitCode = 1
 
@@ -22,7 +26,7 @@ export default async function runNpxCli() {
 // Run if invoked directly (not as a module).
 if (import.meta.url === `file://${process.argv[1]}`) {
   runNpxCli().catch(error => {
-    console.error('Socket npx wrapper error:', error)
+    logger.error('Socket npx wrapper error:', error)
     // eslint-disable-next-line n/no-process-exit
     process.exit(1)
   })
diff --git a/packages/cli/src/pnpm-cli.mts b/packages/cli/src/pnpm-cli.mts
@@ -1,7 +1,11 @@
 #!/usr/bin/env node
 
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
+
 import shadowPnpmBin from './shadow/pnpm/bin.mts'
 
+const logger = getDefaultLogger()
+
 export default async function runPnpmCli() {
   process.exitCode = 1
 
@@ -24,7 +28,7 @@ export default async function runPnpmCli() {
 // Run if invoked directly (not as a module).
 if (import.meta.url === `file://${process.argv[1]}`) {
   runPnpmCli().catch(error => {
-    console.error('Socket pnpm wrapper error:', error)
+    logger.error('Socket pnpm wrapper error:', error)
     // eslint-disable-next-line n/no-process-exit
     process.exit(1)
   })
diff --git a/packages/cli/src/utils/cli/with-subcommands.mts b/packages/cli/src/utils/cli/with-subcommands.mts
@@ -977,8 +977,8 @@ export function meowOrExit(
 
   // Meow doesn't detect 'version' as an unknown flag, so we do the leg work here.
   if (versionFlag && !hasOwn(cliConfig.flags, 'version')) {
-    // Use `console.error` here instead of `getDefaultLogger().error` to match Meow behavior.
-    console.error('Unknown flag\n--version')
+    const logger = getDefaultLogger()
+    logger.error('Unknown flag\n--version')
     // eslint-disable-next-line n/no-process-exit
     process.exit(2)
     // This line is never reached in production, but helps tests.
diff --git a/packages/cli/src/utils/manifest/patches.mts b/packages/cli/src/utils/manifest/patches.mts
@@ -26,6 +26,9 @@ import { dirname, join } from 'node:path'
 import { z } from 'zod'
 
 import { safeMkdir } from '@socketsecurity/lib/fs'
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
+
+const logger = getDefaultLogger()
 
 const MANIFEST_VERSION = '1.0.0'
 const MANIFEST_PATH = '.socket/manifest.json'
@@ -339,7 +342,7 @@ export async function migrateHashes(cwd?: string): Promise<number> {
       // recompute the hash. The migration would need to read all backed-up files
       // from the cache, which is beyond the scope of this metadata operation.
       if (fileInfo.beforeHash.startsWith('git-sha256-')) {
-        console.warn(
+        logger.warn(
           `Legacy git-sha256 hash detected for ${purl}:${filePath}. ` +
             'Manual migration required - see convertToSsri() in patch-hash.mts',
         )
@@ -348,7 +351,7 @@ export async function migrateHashes(cwd?: string): Promise<number> {
 
       // Check if afterHash is legacy format.
       if (fileInfo.afterHash.startsWith('git-sha256-')) {
-        console.warn(
+        logger.warn(
           `Legacy git-sha256 hash detected for ${purl}:${filePath}. ` +
             'Manual migration required - see convertToSsri() in patch-hash.mts',
         )
diff --git a/packages/cli/src/utils/registry/npm-registry.mts b/packages/cli/src/utils/registry/npm-registry.mts
@@ -24,6 +24,9 @@ import path from 'node:path'
 import { parseTarGzip } from 'nanotar'
 
 import { safeMkdir } from '@socketsecurity/lib/fs'
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
+
+const logger = getDefaultLogger()
 
 // Type helpers.
 type TarFile = Awaited<ReturnType<typeof parseTarGzip>>[number]
@@ -324,7 +327,7 @@ export async function extractTarball(
             await retryWithBackoff(() => fs.chmod(targetPath, mode)).catch(
               error => {
                 // Chmod failures are non-fatal - log but continue.
-                console.warn(
+                logger.warn(
                   `Warning: Failed to set permissions for ${targetPath}: ${error instanceof Error ? error.message : String(error)}`,
                 )
               },
@@ -355,7 +358,7 @@ export async function verifyTarballIntegrity(
   integrity?: string,
 ): Promise<boolean> {
   if (!integrity) {
-    console.warn(
+    logger.warn(
       `Warning: No integrity value provided for ${filePath}, skipping verification`,
     )
     return true
@@ -365,7 +368,7 @@ export async function verifyTarballIntegrity(
     // Parse SRI format: "sha512-base64hash=="
     const match = /^(sha\d+)-(.+)$/.exec(integrity)
     if (!match) {
-      console.warn(`Warning: Invalid integrity format: ${integrity}`)
+      logger.warn(`Warning: Invalid integrity format: ${integrity}`)
       return false
     }
 
@@ -385,14 +388,14 @@ export async function verifyTarballIntegrity(
     const isValid = actualHash === expectedHash
 
     if (!isValid) {
-      console.error(
+      logger.error(
         `Integrity mismatch for ${filePath}: expected ${expectedHash.slice(0, 12)}..., got ${actualHash.slice(0, 12)}...`,
       )
     }
 
     return isValid
   } catch (error) {
-    console.error(
+    logger.error(
       `Failed to verify integrity for ${filePath}: ${error instanceof Error ? error.message : String(error)}`,
     )
     return false
diff --git a/packages/cli/src/utils/sea/build.mts b/packages/cli/src/utils/sea/build.mts
@@ -10,12 +10,15 @@ import path from 'node:path'
 import { WIN32 } from '@socketsecurity/lib/constants/platform'
 import { safeDelete, safeMkdir } from '@socketsecurity/lib/fs'
 import { httpRequest } from '@socketsecurity/lib/http-request'
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
 import { normalizePath } from '@socketsecurity/lib/path'
 import { getSocketHomePath } from '@socketsecurity/lib/paths'
 import { spawn } from '@socketsecurity/lib/spawn'
 
 import ENV from '../../constants/env.mts'
 
+const logger = getDefaultLogger()
+
 export interface BuildTargetOptions {
   arch: string
   nodeVersion: string
@@ -417,7 +420,7 @@ export async function injectSeaBlob(
       // codesign not available.
     }
     if (!codesignAvailable) {
-      console.warn(
+      logger.warn(
         'Warning: codesign not found. The binary may not work correctly on macOS.\n' +
           'Install Xcode Command Line Tools: xcode-select --install',
       )
diff --git a/packages/cli/src/utils/terminal/FramedHeader.mts b/packages/cli/src/utils/terminal/FramedHeader.mts
@@ -4,10 +4,14 @@
  * Provides a bordered container for the animated Socket CLI header using ANSI escape codes.
  */
 
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
+
 import { renderShimmerFrame } from './ascii-header.mts'
 
 import type { HeaderTheme } from './ascii-header.mts'
 
+const logger = getDefaultLogger()
+
 export type FramedHeaderProps = {
   animate?: boolean | undefined
   fps?: number | undefined
@@ -50,8 +54,8 @@ export async function renderFramedHeader(
 
     // Move cursor to home and clear from cursor down.
     process.stdout.write('\x1B[H\x1B[J')
-    console.log(`\nTheme: ${theme} | Frame: ${frame}\n`)
-    console.log(framedLogo)
+    logger.log(`\nTheme: ${theme} | Frame: ${frame}\n`)
+    logger.log(framedLogo)
 
     frame++
   }
diff --git a/packages/cli/src/utils/update/notifier.mts b/packages/cli/src/utils/update/notifier.mts
diff --git a/packages/cli/src/yarn-cli.mts b/packages/cli/src/yarn-cli.mts
