Skip to content

Commit 35d4d84

Browse files
authored
fix(optimize): remove Node.js version filter from manifest entries (#1006)
Removes the semver-based Node version check that was filtering manifest entries, allowing all Socket registry overrides to be applied regardless of the Node version specified in package engines.
1 parent 8a0dfb2 commit 35d4d84

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

src/commands/optimize/add-overrides.mts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,21 +109,13 @@ export async function addOverrides(
109109

110110
const depAliasMap = new Map<string, string>()
111111
const depEntries = getDependencyEntries(pkgEnvDetails)
112-
const manifestEntries = manifestNpmOverrides.filter(({ 1: data }) =>
113-
semver.satisfies(
114-
// Roughly check Node range as semver.coerce will strip leading
115-
// v's, carets (^), comparators (<,<=,>,>=,=), and tildes (~).
116-
semver.coerce(data.engines.node)!,
117-
pkgEnvDetails.pkgRequirements.node,
118-
),
119-
)
120112

121113
const addingText = `Adding overrides to ${workspace}...`
122114
let loggedAddingText = false
123115

124116
// Chunk package names to process them in parallel 3 at a time.
125117
await pEach(
126-
manifestEntries,
118+
manifestNpmOverrides,
127119
async ({ 1: data }) => {
128120
const { name: sockRegPkgName, package: origPkgName, version } = data
129121
const major = getMajor(version)!

0 commit comments

Comments
 (0)