Skip to content

Commit 06ef917

Browse files
committed
fix(test): enable all binary types in CI integration tests
Change binary test suite to automatically test all available binaries in CI instead of only testing JS: - JS: Always enabled in CI (was: only if no other env vars set) - SEA: Always enabled in CI (was: only if TEST_SEA_BINARY set) - Smol: Always enabled in CI (was: only if TEST_SMOL_BINARY set) Local behavior unchanged: - Use TEST_JS_BINARY, TEST_SEA_BINARY, TEST_SMOL_BINARY env vars - JS defaults to true if no env vars set Each test suite will skip gracefully if the binary doesn't exist (not cached or not built), so this safely enables testing of all cached binaries without requiring explicit environment variables.
1 parent 3c5ac70 commit 06ef917

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

packages/cli/test/integration/binary/binary-test-suite.test.mts

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,12 @@ const BINARIES = {
2525
__proto__: null,
2626
js: {
2727
buildCommand: null,
28-
enabled:
29-
!process.env.TEST_SEA_BINARY &&
30-
!process.env.TEST_SMOL_BINARY &&
31-
!process.env.TEST_JS_BINARY
28+
// In CI: always enabled. Locally: controlled by env vars (defaults to true).
29+
enabled: process.env.CI
30+
? true
31+
: !process.env.TEST_SEA_BINARY &&
32+
!process.env.TEST_SMOL_BINARY &&
33+
!process.env.TEST_JS_BINARY
3234
? true
3335
: !!process.env.TEST_JS_BINARY,
3436
name: 'JS Distribution (dist/index.js)',
@@ -42,7 +44,8 @@ const BINARIES = {
4244
'run',
4345
'build',
4446
],
45-
enabled: !!process.env.TEST_SEA_BINARY,
47+
// In CI: always enabled. Locally: only if TEST_SEA_BINARY is set.
48+
enabled: process.env.CI ? true : !!process.env.TEST_SEA_BINARY,
4649
name: 'SEA Binary (Single Executable Application)',
4750
path: path.join(MONOREPO_ROOT, 'packages/node-sea-builder/dist/socket-sea'),
4851
},
@@ -54,7 +57,8 @@ const BINARIES = {
5457
'run',
5558
'build',
5659
],
57-
enabled: !!process.env.TEST_SMOL_BINARY,
60+
// In CI: always enabled. Locally: only if TEST_SMOL_BINARY is set.
61+
enabled: process.env.CI ? true : !!process.env.TEST_SMOL_BINARY,
5862
name: 'Smol Binary',
5963
path: path.join(
6064
MONOREPO_ROOT,

0 commit comments

Comments
 (0)