Skip to content

Commit 40bab2f

Browse files
Add name to handlers and refactor.
1 parent 025277e commit 40bab2f

File tree

2 files changed

+9
-30
lines changed

2 files changed

+9
-30
lines changed

src/handlers/api.py

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,21 +48,14 @@ class BaseHandler(BioThingsAuthnMixin, BaseAPIHandler):
4848

4949
class AuthHandler(BaseHandler):
5050
def set_cache_header(self, cache_value):
51-
# disabel cache for auth-related handlers
51+
# disable cache for auth-related handlers
5252
self.set_header("Cache-Control", "private, max-age=0, no-cache")
5353

54-
def prepare(self):
55-
"""Override prepare to bypass parameter validation issues"""
56-
# codacy:disable
57-
super(BaseAPIHandler, self).prepare()
58-
5954

6055
class UserInfoHandler(AuthHandler):
61-
""" "Handler for /user_info endpoint."""
62-
63-
# Define that no parameters are required for this endpoint
56+
""" "Handler for /user endpoint."""
57+
name = "user_info"
6458
kwargs = {
65-
"*": {}, # Override any inherited parameter requirements
6659
"GET": {} # Explicitly empty - no parameters expected or required
6760
}
6861

@@ -84,9 +77,9 @@ def get(self):
8477

8578

8679
class LoginHandler(AuthHandler):
87-
# Define expected parameters for login redirect
80+
""" "Handler for /login endpoint."""
81+
name = "user_login"
8882
kwargs = {
89-
"*": {}, # Override any inherited parameter requirements
9083
"GET": {
9184
"next": {"type": str, "required": False, "default": "/"} # Redirect URL
9285
}
@@ -97,9 +90,9 @@ def get(self):
9790

9891

9992
class LogoutHandler(AuthHandler):
100-
# Define expected parameters for logout redirect
93+
""" "Handler for /logout endpoint."""
94+
name = "user_logout"
10195
kwargs = {
102-
"*": {}, # Override any inherited parameter requirements
10396
"GET": {
10497
"next": {"type": str, "required": False, "default": "/"} # Redirect URL
10598
}

src/handlers/oauth.py

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,12 @@
77

88

99
class GitHubLoginHandler(BaseAPIHandler, GithubOAuth2Mixin):
10-
""" "Handler for GitHub oauth login"""
10+
""" "Handler for GitHub oauth login: /oauth endpoint"""
11+
name = "github_oauth"
1112

1213
SCOPES = []
1314
GITHUB_CALLBACK_PATH = "/oauth"
1415

15-
# Define expected parameters properly - override any inherited parameter validation
16-
kwargs = {
17-
"*": {}, # Override any inherited parameter requirements
18-
"GET": {
19-
"code": {"type": str, "required": False}, # OAuth callback code
20-
"next": {"type": str, "required": False, "default": "/"}, # Redirect URL
21-
"state": {"type": str, "required": False}, # OAuth state parameter
22-
}
23-
}
24-
25-
def prepare(self):
26-
"""Override prepare to bypass parameter validation issues"""
27-
# codacy:disable
28-
super(BaseAPIHandler, self).prepare()
29-
3016
async def get(self):
3117
CLIENT_ID = self.biothings.config.GITHUB_CLIENT_ID
3218
CLIENT_SECRET = self.biothings.config.GITHUB_CLIENT_SECRET

0 commit comments

Comments
 (0)