From f7883158edd622b8eb2ce2a993a36ef1a19567ae Mon Sep 17 00:00:00 2001 From: Eric Lee Date: Thu, 13 Nov 2025 23:27:04 -0800 Subject: [PATCH] Add erroring for when variables are given for aBulkOps query --- .../services/bulk-operations/execute-bulk-operation.ts | 10 +++++++++- .../app/src/cli/services/bulk-operations/run-query.ts | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/app/src/cli/services/bulk-operations/execute-bulk-operation.ts b/packages/app/src/cli/services/bulk-operations/execute-bulk-operation.ts index f0cca19ea8..6617533249 100644 --- a/packages/app/src/cli/services/bulk-operations/execute-bulk-operation.ts +++ b/packages/app/src/cli/services/bulk-operations/execute-bulk-operation.ts @@ -4,6 +4,7 @@ import {AppLinkedInterface} from '../../models/app/app.js' import {renderSuccess, renderInfo, renderWarning} from '@shopify/cli-kit/node/ui' import {outputContent, outputToken} from '@shopify/cli-kit/node/output' import {ensureAuthenticatedAdmin} from '@shopify/cli-kit/node/session' +import {AbortError} from '@shopify/cli-kit/node/error' import {parse} from 'graphql' interface ExecuteBulkOperationInput { @@ -23,7 +24,14 @@ export async function executeBulkOperation(input: ExecuteBulkOperationInput): Pr const adminSession = await ensureAuthenticatedAdmin(storeFqdn) - const bulkOperationResponse = isMutation(query) + const operationIsMutation = isMutation(query) + if (!operationIsMutation && variables) { + throw new AbortError( + outputContent`The ${outputToken.yellow('--variables')} flag can only be used with mutations, not queries.`, + ) + } + + const bulkOperationResponse = operationIsMutation ? await runBulkOperationMutation({adminSession, query, variables}) : await runBulkOperationQuery({adminSession, query}) diff --git a/packages/app/src/cli/services/bulk-operations/run-query.ts b/packages/app/src/cli/services/bulk-operations/run-query.ts index e093b7ccf3..716944dd73 100644 --- a/packages/app/src/cli/services/bulk-operations/run-query.ts +++ b/packages/app/src/cli/services/bulk-operations/run-query.ts @@ -14,6 +14,7 @@ export async function runBulkOperationQuery( options: BulkOperationRunQueryOptions, ): Promise { const {adminSession, query} = options + const response = await adminRequestDoc({ query: BulkOperationRunQuery, session: adminSession,