Update to Npgsql v4.0.1

Author: mythz

NuGet/ServiceStack.OrmLite.PostgreSQL.Core/servicestack.ormlite.postgresql.core.nuspec

@@ -18,7 +18,7 @@
     <copyright>ServiceStack and contributors</copyright>
     <dependencies>
       <group targetFramework=".netstandard2.0">
-        <dependency id="Npgsql" version="[3.2.7, )" />
+        <dependency id="Npgsql" version="[4.0.1, )" />
         <dependency id="ServiceStack.OrmLite.Core" version="5.0.0" />
       </group>
     </dependencies>

NuGet/ServiceStack.OrmLite.PostgreSQL/servicestack.ormlite.postgresql.nuspec

@@ -19,11 +19,11 @@
     <copyright>ServiceStack and contributors</copyright>
     <dependencies>
       <group targetFramework="net45">
-        <dependency id="Npgsql" version="[3.2.7, )" />
+        <dependency id="Npgsql" version="[4.0.1, )" />
         <dependency id="ServiceStack.OrmLite" version="5.0.0" />
       </group>
       <group targetFramework=".netstandard2.0">
-        <dependency id="Npgsql" version="[3.2.7, )" />
+        <dependency id="Npgsql" version="[4.0.1, )" />
         <dependency id="ServiceStack.OrmLite" version="5.0.0" />
       </group>
     </dependencies>

src/ServiceStack.OrmLite.PostgreSQL.Tests/ServiceStack.OrmLite.PostgreSQL.Tests.csproj

@@ -26,7 +26,7 @@
     <PackageReference Include="NUnit3TestAdapter" Version="3.10.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.8.0-preview-20180610-02" />
     <PackageReference Include="NUnit" Version="3.10.1" />
-    <PackageReference Include="Npgsql" Version="4.0.0" />
+    <PackageReference Include="Npgsql" Version="4.0.1" />
   </ItemGroup>
 
   <PropertyGroup Condition=" '$(TargetFramework)' == 'net46' ">

src/ServiceStack.OrmLite.PostgreSQL/PostgreSQLDialectProvider.cs

@@ -256,17 +256,19 @@ public override void PrepareParameterizedInsertStatement<T>(IDbCommand cmd, ICol
 
             foreach (var fieldDef in modelDef.FieldDefinitionsArray)
             {
-                if (ShouldReturnOnInsert(modelDef, fieldDef))
+                //insertFields contains Property "Name" of fields to insert
+                var includeField = insertFields == null || insertFields.Contains(fieldDef.Name, StringComparer.OrdinalIgnoreCase);
+
+                if (ShouldReturnOnInsert(modelDef, fieldDef) && (!fieldDef.AutoId || !includeField))
                 {
-                    sbReturningColumns.Append(sbReturningColumns.Length == 0 ? "RETURNING " : ",");
+                    sbReturningColumns.Append(sbReturningColumns.Length == 0 ? " RETURNING " : ",");
                     sbReturningColumns.Append(GetQuotedColumnName(fieldDef.FieldName));
                 }
 
-                if (ShouldSkipInsert(fieldDef))
+                if (ShouldSkipInsert(fieldDef) && (!fieldDef.AutoId || !includeField))
                     continue;
 
-                //insertFields contains Property "Name" of fields to insert ( that's how expressions work )
-                if (insertFields != null && !insertFields.Contains(fieldDef.Name, StringComparer.OrdinalIgnoreCase))
+                if (!includeField)
                     continue;
 
                 if (sbColumnNames.Length > 0)

src/ServiceStack.OrmLite.PostgreSQL/ServiceStack.OrmLite.PostgreSQL.csproj

@@ -21,7 +21,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Npgsql" Version="4.0.0" />
+    <PackageReference Include="Npgsql" Version="4.0.1" />
   </ItemGroup>
 
   <PropertyGroup Condition=" '$(TargetFramework)' == 'net45' ">

src/ServiceStack.OrmLite/OrmLiteUtils.cs

@@ -971,9 +971,6 @@ public static List<string> GetNonDefaultValueInsertFields<T>(this IOrmLiteDialec
             {
                 if (!string.IsNullOrEmpty(dialectProvider.GetDefaultValue(fieldDef)))
                 {
-                    if (fieldDef.AutoId)
-                        continue;
-                    
                     var value = fieldDef.GetValue(obj);    
                     if (value == null || value.Equals(fieldDef.FieldTypeDefaultValue))
                         continue;

tests/ServiceStack.OrmLite.Tests/MaxDataTypeTests.cs

@@ -10,15 +10,15 @@ public class MaxDataTypeTests : OrmLiteTestBase
         [Test]
         public void Can_insert_and_select_max_values()
         {
-            //OrmLiteConfig.ThrowOnError = true;
+            OrmLiteConfig.ThrowOnError = true;
             var isSqlServer = (Dialect & Dialect.AnySqlServer) == Dialect;
 
             var model = new ModelWithFieldsOfDifferentTypes
             {
                 Int = int.MaxValue,
                 Long = long.MaxValue,
                 Double = double.MaxValue,
-                Decimal = !isSqlServer && Dialect != Dialect.Sqlite
+                Decimal = !isSqlServer && Dialect != Dialect.Sqlite && Dialect != Dialect.PostgreSql
                     ? Decimal.MaxValue
                     : long.MaxValue,
                 DateTime = Dialect != Dialect.MySql