fix trace upload issue in exception; ffmpeg fix

Author: SentienceDEV

sentience/agent.py

@@ -206,10 +206,10 @@ def act(  # noqa: C901
             )
 
         # Track data collected during step execution for step_end emission on failure
-        _step_snap_with_diff: Optional[Snapshot] = None
-        _step_pre_url: Optional[str] = None
-        _step_llm_response: Optional[LLMResponse] = None
-        _step_result: Optional[AgentActionResult] = None
+        _step_snap_with_diff: Snapshot | None = None
+        _step_pre_url: str | None = None
+        _step_llm_response: LLMResponse | None = None
+        _step_result: AgentActionResult | None = None
         _step_duration_ms: int = 0
 
         for attempt in range(max_retries + 1):
@@ -564,7 +564,9 @@ def act(  # noqa: C901
                         snapshot_digest = f"sha256:{self._compute_hash(f'{_step_pre_url}{_step_snap_with_diff.timestamp}')}"
 
                         # Build pre_elements from snap_with_diff (includes diff_status)
-                        snapshot_event_data = TraceEventBuilder.build_snapshot_event(_step_snap_with_diff)
+                        snapshot_event_data = TraceEventBuilder.build_snapshot_event(
+                            _step_snap_with_diff
+                        )
                         pre_elements = snapshot_event_data.get("elements", [])
 
                         # Build LLM data if available
@@ -847,10 +849,10 @@ async def act(  # noqa: C901
             )
 
         # Track data collected during step execution for step_end emission on failure
-        _step_snap_with_diff: Optional[Snapshot] = None
-        _step_pre_url: Optional[str] = None
-        _step_llm_response: Optional[LLMResponse] = None
-        _step_result: Optional[AgentActionResult] = None
+        _step_snap_with_diff: Snapshot | None = None
+        _step_pre_url: str | None = None
+        _step_llm_response: LLMResponse | None = None
+        _step_result: AgentActionResult | None = None
         _step_duration_ms: int = 0
 
         for attempt in range(max_retries + 1):
@@ -1204,7 +1206,9 @@ async def act(  # noqa: C901
                         snapshot_digest = f"sha256:{self._compute_hash(f'{_step_pre_url}{_step_snap_with_diff.timestamp}')}"
 
                         # Build pre_elements from snap_with_diff (includes diff_status)
-                        snapshot_event_data = TraceEventBuilder.build_snapshot_event(_step_snap_with_diff)
+                        snapshot_event_data = TraceEventBuilder.build_snapshot_event(
+                            _step_snap_with_diff
+                        )
                         pre_elements = snapshot_event_data.get("elements", [])
 
                         # Build LLM data if available

sentience/agent_runtime.py

@@ -583,7 +583,7 @@ def assert_done(
             True if task is complete (assertion passed), False otherwise
         """
         # Convenience wrapper for assert_ with required=True
-        ok = self.assert_(predicate, label=label, required=True)
+        ok = self.assertTrue(predicate, label=label, required=True)
         if ok:
             self._task_done = True
             self._task_done_label = label

sentience/failure_artifacts.py

@@ -239,9 +239,7 @@ def _generate_clip_from_frames(
         if result.returncode != 0:
             stderr = result.stderr.decode("utf-8", errors="replace")[:500]
             stdout = result.stdout.decode("utf-8", errors="replace")[:200]
-            logger.warning(
-                f"ffmpeg failed with return code {result.returncode}: {stderr}"
-            )
+            logger.warning(f"ffmpeg failed with return code {result.returncode}: {stderr}")
             if stdout:
                 logger.debug(f"ffmpeg stdout: {stdout}")
             # Fallback: use glob input (handles non-uniform filenames)