Code Review: Applied various suggestions

Author: Seluj78

.github/workflows/tests.yml

@@ -15,7 +15,6 @@ jobs:
       fail-fast: false
       matrix:
         python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
-        flask-version: ["2.0", "2.1", "2.2", "2.3", "3.0"]
 
     steps:
     - name: Check out repository
@@ -34,6 +33,5 @@ jobs:
     - name: Run tests
       run: |
         PYTHON_VERSION=${{ matrix.python-version }}
-        FLASK_VERSION=${{ matrix.flask-version }}
-        TOX_ENV="py${PYTHON_VERSION//./}-flask${FLASK_VERSION//./}"
+        TOX_ENV="py${PYTHON_VERSION//./}
         tox -e $TOX_ENV

README.md

@@ -48,7 +48,7 @@ Run the tests multi-threaded
 tox -p
 ```
 
-# TODO:
+# TODO
 
 - [ ] Documentation
 - [ ] Licence

flask_utils/errors/base_class.py

@@ -5,4 +5,3 @@ class BaseFlaskException(Exception):
     name: Optional[str] = None
     msg: Optional[str] = None
     solution: str = "Try again."
-    pass

flask_utils/errors/conflict.py

@@ -7,7 +7,7 @@ class ConflictError(BaseFlaskException):
     """
 
     def __init__(self, msg: str, solution: str = "Try again.") -> None:
-        self.name = "Conflict Error"
+        self.name = "Conflict"
         self.msg = msg
         self.solution = solution
         self.status_code = 409

flask_utils/errors/forbidden.py

@@ -7,7 +7,7 @@ class ForbiddenError(BaseFlaskException):
     """
 
     def __init__(self, msg: str, solution: str = "Try again.") -> None:
-        self.name = "Forbidden Error"
+        self.name = "Forbidden"
         self.msg = msg
         self.solution = solution
         self.status_code = 403

flask_utils/errors/notfound.py

@@ -7,7 +7,7 @@ class NotFoundError(BaseFlaskException):
     """
 
     def __init__(self, msg: str, solution: str = "Try again.") -> None:
-        self.name = "Not Found Error"
+        self.name = "Not Found"
         self.msg = msg
         self.solution = solution
         self.status_code = 404

flask_utils/errors/origin_is_unreachable.py

@@ -7,7 +7,7 @@ class OriginIsUnreachableError(BaseFlaskException):
     """
 
     def __init__(self, msg: str, solution: str = "Try again later.") -> None:
-        self.name = "Origin Is Unreachable"
+        self.name = "Origin is unreachable"
         self.msg = msg
         self.solution = solution
         self.status_code = 523

flask_utils/errors/unauthorized.py

@@ -7,7 +7,7 @@ class UnauthorizedError(BaseFlaskException):
     """
 
     def __init__(self, msg: str, solution: str = "Try again.") -> None:
-        self.name = "Unauthorized Error"
+        self.name = "Unauthorized"
         self.msg = msg
         self.solution = solution
         self.status_code = 401

scripts/check_version.py

@@ -4,16 +4,15 @@
 from packaging import version
 
 
-cat_cmd = subprocess.Popen(("cat", "flask_utils/__init__.py"), stdout=subprocess.PIPE)
-output = subprocess.check_output(("grep", "__version__"), stdin=cat_cmd.stdout).decode("utf-8").strip()
-cat_cmd.wait()
+with open("flask_utils/__init__.py", "r") as file:
+    content = file.read()
 
 
 # Regular expression pattern to find the version
 version_pattern = r'__version__ = "([0-9]+\.[0-9]+\.[0-9]+)"'
 
 # Search for the pattern and extract the version
-match = re.search(version_pattern, output)
+match = re.search(version_pattern, content)
 if match:
     current_version = match.group(1)
 else:

tox.ini

@@ -1,12 +1,12 @@
 [tox]
-envlist = py{38,39,310,311,312}-flask{2,21,22,23,3}
+envlist = py{38,39,310,311,312}-flask{20,21,22,23,30}
 
 [testenv]
 deps =
     pytest
-    flask2: Flask==2.*
+    flask20: Flask==2.*
     flask21: Flask==2.*
     flask22: Flask==2.*
     flask23: Flask==2.*
-    flask3: Flask==3.*
+    flask30: Flask==3.*
 commands = pytest