Proposal how to fix TODO

[Toflar]

I'm don't know why exactly you have to stop script execution here:

Shel.Neos.Terminal/Classes/Command/FlushCacheCommand.php

Line 73 in bf3f1e7

header('Content-Type: application/json');

But I assume there are technical reasons for it. I've encountered the same in the past and I've solved it by throwing a custom exception which you can then catch in the controller.
Not aborting the script execution has a few advantages:

• You don't miss setting the Content-Length header like it is now ;-)
• You can continue the script execution flow which means events etc. can still be fired after that before e.g. the response is sent to the client
• Debugging scripts can continue to work
• etc.

Just as an idea ;-) Over at Contao we even built a ResponseException which takes a Symfony HttpFoundation Response as argument so you can send a proper response from within legacy code :-)

[Sebobo]

Hi @Toflar,

thanks for the idea!

Most of the time the command would work fine without early exit. But when flushing the Flow framework caches including reflection classes I encountered random exceptions during the shutdown phase of the framework.
Basically code was gone it still relied on.

So going back to the controller with an exception doesn't solve it or I didn't fully understand what you meant.

But after playing around it looks like the errors I encountered came from the persistence layer. So I tried clearing the persistence state after flushing, and so far I didn't encounter further errors when flushing all caches and returning a proper response.

So I will play with it for a few days and see if it actually works now :)
If not, maybe I can further influence the shutdown phase and skip some steps.

But I'm curious how you found this little todo?

[Toflar]

But I'm curious how you found this little todo?

I guess I'm trying to take my Neos Award jury seat seriously ;-) That's how I found it and I thought I might as well drop a few lines while I'm here :-)