From d3b692e85de3573f67d85958a9d07ed719bebadc Mon Sep 17 00:00:00 2001 From: Jicheng Lu Date: Thu, 5 Feb 2026 21:11:31 -0600 Subject: [PATCH 1/3] add query and arg logs in membase --- .../BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs b/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs index e65958ea9..700e8d665 100644 --- a/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs +++ b/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs @@ -1,6 +1,8 @@ using BotSharp.Abstraction.Graph; using BotSharp.Abstraction.Graph.Models; using BotSharp.Abstraction.Graph.Options; +using BotSharp.Abstraction.Models; +using BotSharp.Abstraction.Utilities; using Microsoft.Extensions.Logging; using System.Text.Json; @@ -31,12 +33,14 @@ public async Task ExecuteQueryAsync(string query, GraphQueryEx throw new ArgumentException($"Please provide a valid {Provider} graph id."); } + var args = options?.Arguments ?? new(); + try { var response = await _membaseApi.CypherQueryAsync(options.GraphId, new CypherQueryRequest { Query = query, - Parameters = options.Arguments ?? new Dictionary() + Parameters = args }); return new GraphQueryResult @@ -48,7 +52,8 @@ public async Task ExecuteQueryAsync(string query, GraphQueryEx } catch (Exception ex) { - _logger.LogError(ex, $"Error when executing query in {Provider} graph db."); + var argLogs = args.Select(x => (new KeyValue(x.Key, x.Value.ConvertToString())).ToString()); + _logger.LogError(ex, $"Error when executing query in {Provider} graph db. (Query: {query}, Argments: {string.Join("\r\n", argLogs)})"); return new(); } } From 6a2324b9a53be070b778f36479e9ab5ef711e885 Mon Sep 17 00:00:00 2001 From: Jicheng Lu Date: Thu, 5 Feb 2026 21:41:12 -0600 Subject: [PATCH 2/3] minor change --- src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs b/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs index 700e8d665..541df5445 100644 --- a/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs +++ b/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs @@ -53,7 +53,7 @@ public async Task ExecuteQueryAsync(string query, GraphQueryEx catch (Exception ex) { var argLogs = args.Select(x => (new KeyValue(x.Key, x.Value.ConvertToString())).ToString()); - _logger.LogError(ex, $"Error when executing query in {Provider} graph db. (Query: {query}, Argments: {string.Join("\r\n", argLogs)})"); + _logger.LogError(ex, $"Error when executing query in {Provider} graph db. (Query: {query}), (Argments: \r\n{string.Join("\r\n", argLogs)})"); return new(); } } From 1c48cae04ebe538c8782d3db67c814884f3a2b2c Mon Sep 17 00:00:00 2001 From: Jicheng Lu Date: Thu, 5 Feb 2026 21:48:45 -0600 Subject: [PATCH 3/3] use default json options --- src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs b/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs index 541df5445..1bcca821d 100644 --- a/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs +++ b/src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs @@ -2,6 +2,7 @@ using BotSharp.Abstraction.Graph.Models; using BotSharp.Abstraction.Graph.Options; using BotSharp.Abstraction.Models; +using BotSharp.Abstraction.Options; using BotSharp.Abstraction.Utilities; using Microsoft.Extensions.Logging; using System.Text.Json; @@ -52,7 +53,7 @@ public async Task ExecuteQueryAsync(string query, GraphQueryEx } catch (Exception ex) { - var argLogs = args.Select(x => (new KeyValue(x.Key, x.Value.ConvertToString())).ToString()); + var argLogs = args.Select(x => (new KeyValue(x.Key, x.Value.ConvertToString(BotSharpOptions.defaultJsonOptions))).ToString()); _logger.LogError(ex, $"Error when executing query in {Provider} graph db. (Query: {query}), (Argments: \r\n{string.Join("\r\n", argLogs)})"); return new(); }